Rename "model" fields with "dtdlModel" or "dtmiModel" to be more descriptive #16776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
Author
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
bikamani
changed the title
bikamani
requested review from
abhipsaMisra,
azabbasi,
barustum,
drwill-ms,
timtay-microsoft and
vinagesh
as code owners
drwill-ms
reviewed
Oct 23, 2020
...igitaltwins-core/src/main/java/com/azure/digitaltwins/core/models/DigitalTwinsModelData.java
Outdated
Show resolved
Hide resolved
timtay-microsoft
approved these changes
Oct 23, 2020
Contributor
Author
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
drwill-ms
reviewed
Oct 23, 2020
|
|
||
| /* | ||
| * The model definition. | ||
| * The model definition that conforms to the Digital Twins Definition Language (DTDL) v2. |
There was a problem hiding this comment.
Can you add a link to the documentation, like I did in the .NET PR? Check your work item for a link.
Contributor
Author
There was a problem hiding this comment.
I will take care of this in next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.