Removed dependencies on netty and reactor-core. Taking dependencies from azure-core and azure-core-http-netty#16604
Merged
kushagraThapar merged 1 commit intoAzure:masterfrom Oct 21, 2020
Conversation
…ndencies from azure-core and azure-core-http-netty
kushagraThapar
requested review from
David-Noble-at-work,
kirankumarkolli,
mbhaskar,
milismsft,
moderakh,
simplynaveen20 and
xinlian12
as code owners
ghost
added
the
moderakh
approved these changes
Oct 20, 2020
Contributor
moderakh
left a comment
moderakh
left a comment
There was a problem hiding this comment.
this is as we discussed offline.
Looks good to me. Thank you.
If all CIs pass we should check this in :-)
Member
Author
|
/azp run java - cosmos - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
milismsft
approved these changes
Oct 20, 2020
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chenrujun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.