Skip to content

Removed ability to take a share or share snapshot lease #16603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gapra-msft merged 3 commits into from
Oct 23, 2020
Merged

Removed ability to take a share or share snapshot lease #16603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccbd017
Removed ability to take a share or share snapshot lease
gapra-msft Oct 20, 2020
bcd845e
change to changelof
gapra-msft Oct 21, 2020
ef0c135
changelog
gapra-msft Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdk/storage/azure-storage-file-share/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@
- Added support for getting access tier on a share through ShareClient.getProperties, ShareServiceClient.listShares
- Renamed setAccessTier to setProperties and deprecated setQuotaInGb in favor of setProperties.
- Renamed DeleteSnapshotsOptionType to ShareSnapshotsDeleteOptionType in ShareClient.delete
- Removed ability to create a ShareLeaseClient for a Share or Share Snapshot. This feature has been rescheduled for future release.

## 12.7.0-beta.1 (2020-10-01)
- Added support for the 2020-02-10 service version.
- Added support to getFileRanges on a previous snapshot by adding the getFileRangesDiff API.
- Added support to set whether or not smb multichannel is enabled.
- Added support to lease shares and snapshot shares.
- Added support to specify a lease id for share operations.
- Added support to specify a lease id for share operations.
- Fixed a bug where getProperties on a file client would throw a HttpResponseException instead of ShareStorageException.
- Fixed a bug where snapshot would be appended to a share snapshot instead of sharesnapshot.
- Fixed a bug that would cause auth failures when building a client by passing an endpoint which had a sas token with protocol set to https,http
Expand Down
4 changes: 2 additions & 2 deletions ...share/src/main/java/com/azure/storage/file/share/specialized/ShareLeaseClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public ShareLeaseClientBuilder fileAsyncClient(ShareFileAsyncClient fileAsyncCli
* @return the updated ShareLeaseClientBuilder object
* @throws NullPointerException If {@code fileClient} is {@code null}.
*/
public ShareLeaseClientBuilder shareClient(ShareClient shareClient) {
ShareLeaseClientBuilder shareClient(ShareClient shareClient) {
Objects.requireNonNull(shareClient);
this.pipeline = shareClient.getHttpPipeline();
this.url = shareClient.getShareUrl();
Expand All @@ -130,7 +130,7 @@ public ShareLeaseClientBuilder shareClient(ShareClient shareClient) {
* @return the updated ShareLeaseClientBuilder object
* @throws NullPointerException If {@code fileAsyncClient} is {@code null}.
*/
public ShareLeaseClientBuilder shareAsyncClient(ShareAsyncClient shareAsyncClient) {
ShareLeaseClientBuilder shareAsyncClient(ShareAsyncClient shareAsyncClient) {
Objects.requireNonNull(shareAsyncClient);
this.pipeline = shareAsyncClient.getHttpPipeline();
this.url = shareAsyncClient.getShareUrl();
Expand Down