Update ContinuablePagedFluxCore Page Retrieving Logic#15929
Merged
alzimmermsft merged 5 commits intoAzure:masterfrom Oct 5, 2020
Merged
Update ContinuablePagedFluxCore Page Retrieving Logic#15929alzimmermsft merged 5 commits intoAzure:masterfrom
alzimmermsft merged 5 commits intoAzure:masterfrom
Conversation
srnagar
approved these changes
Oct 5, 2020
sdk/core/azure-core/src/main/java/com/azure/core/util/paging/ContinuablePagedFluxCore.java
Show resolved
Hide resolved
anuchandy
approved these changes
Oct 5, 2020
sdk/core/azure-core/src/main/java/com/azure/core/util/paging/ContinuablePagedFluxCore.java
Show resolved
Hide resolved
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the page retrieving logic of
ContinuablePagedFluxCore.Previously, it used Reactor's
concatWithrecursively, this functioned correctly but had the unforeseen side affect of which each page retrieval Reactor would instantiate an internal buffer withlength + 1. When dealing with restrictive memory scenarios and a large page count this could result in anOutOfMemoryError.Now, it uses Reactor's
expandfunctionality, which is loosely akin to ado/whileloop that doesn't terminate until thedofunction returns a completion signal (either an emptyMono/Fluxor an exception). This doesn't have the same side affects as the recursiveconcatWithwhere it needs to continually increment an internal buffer for each page retrieval, leading to more consistent memory usage with less overall spike and smaller GCs.