Skip to content

[Service Bus] Change getter of boolean values to isXyz() #15890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YijunXieMS merged 7 commits into from
Oct 29, 2020
Merged

[Service Bus] Change getter of boolean values to isXyz() #15890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
73614e7
Change getter of boolean values to isXXX()
YijunXieMS Oct 2, 2020
4f505d4
Fixing a typo
YijunXieMS Oct 2, 2020
2f50ff1
Change getter of boolean values to isXXX()
YijunXieMS Oct 2, 2020
73ccf5b
Fixing a typo
YijunXieMS Oct 2, 2020
7243bc4
Merge branch 'sb_bool' of github.com:YijunXieMS/azure-sdk-for-java in…
YijunXieMS Oct 28, 2020
3939d71
Rename boolean setters
YijunXieMS Oct 28, 2020
07c289b
Merge branch 'master' into sb_bool
YijunXieMS Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions ...rc/main/java/com/azure/messaging/servicebus/administration/models/CreateQueueOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,12 @@ public class CreateQueueOptions {
* <li>{@link #setDefaultMessageTimeToLive(Duration)} is max duration value.</li>
* <li>{@link #setDuplicateDetectionHistoryTimeWindow(Duration)} is max duration value, but duplication
* detection is disabled.</li>
* <li>{@link #setRequiresDuplicateDetection(boolean)} is false.</li>
* <li>{@link #setEnableBatchedOperations(boolean)} is true.</li>
* <li>{@link #setDuplicateDetectionRequired(boolean)} is false.</li>
* <li>{@link #setBatchedOperationsEnabled(boolean)} is true.</li>
* <li>{@link #setLockDuration(Duration)} is 1 minute.</li>
* <li>{@link #setMaxDeliveryCount(int)} is 10.</li>
* <li>{@link #setMaxSizeInMegabytes(int)} is 1024MB.</li>
* <li>{@link #setRequiresSession(boolean)} is false.</li>
* <li>{@link #setSessionRequired(boolean)} is false.</li>
* <li>{@link #setStatus(EntityStatus)} is {@link EntityStatus#ACTIVE}.</li>
* </ul>
*
Expand Down Expand Up @@ -98,16 +98,16 @@ public CreateQueueOptions(QueueProperties queue) {
this.duplicateDetectionHistoryTimeWindow = queue.getDuplicateDetectionHistoryTimeWindow() != null
? queue.getDuplicateDetectionHistoryTimeWindow()
: DEFAULT_DUPLICATE_DETECTION_DURATION;
this.enableBatchedOperations = queue.enableBatchedOperations();
this.enablePartitioning = queue.enablePartitioning();
this.enableBatchedOperations = queue.isBatchedOperationsEnabled();
this.enablePartitioning = queue.isPartitioningEnabled();
this.forwardTo = queue.getForwardTo();
this.forwardDeadLetteredMessagesTo = queue.getForwardDeadLetteredMessagesTo();
this.lockDuration = queue.getLockDuration();

this.maxDeliveryCount = queue.getMaxDeliveryCount();
this.maxSizeInMegabytes = queue.getMaxSizeInMegabytes();
this.requiresDuplicateDetection = queue.requiresDuplicateDetection();
this.requiresSession = queue.requiresSession();
this.requiresDuplicateDetection = queue.isDuplicateDetectionRequired();
this.requiresSession = queue.isSessionRequired();
this.status = queue.getStatus();
this.userMetadata = queue.getUserMetadata();
}
Expand Down Expand Up @@ -175,7 +175,7 @@ public CreateQueueOptions setDefaultMessageTimeToLive(Duration defaultMessageTim
*
* @return the deadLetteringOnMessageExpiration value.
*/
public boolean deadLetteringOnMessageExpiration() {
public boolean isDeadLetteringOnMessageExpiration() {
return this.deadLetteringOnMessageExpiration;
}

Expand Down Expand Up @@ -221,7 +221,7 @@ public CreateQueueOptions setDuplicateDetectionHistoryTimeWindow(Duration duplic
*
* @return the enableBatchedOperations value.
*/
public boolean enableBatchedOperations() {
public boolean isBatchedOperationsEnabled() {
return this.enableBatchedOperations;
}

Expand All @@ -233,7 +233,7 @@ public boolean enableBatchedOperations() {
*
* @return the CreateQueueOptions object itself.
*/
public CreateQueueOptions setEnableBatchedOperations(boolean enableBatchedOperations) {
public CreateQueueOptions setBatchedOperationsEnabled(boolean enableBatchedOperations) {
this.enableBatchedOperations = enableBatchedOperations;
return this;
}
Expand All @@ -244,7 +244,7 @@ public CreateQueueOptions setEnableBatchedOperations(boolean enableBatchedOperat
*
* @return the enablePartitioning value.
*/
public boolean enablePartitioning() {
public boolean isPartitioningEnabled() {
return this.enablePartitioning;
}

Expand All @@ -256,7 +256,7 @@ public boolean enablePartitioning() {
*
* @return the CreateQueueOptions object itself.
*/
public CreateQueueOptions setEnablePartitioning(boolean enablePartitioning) {
public CreateQueueOptions setPartitioningEnabled(boolean enablePartitioning) {
this.enablePartitioning = enablePartitioning;
return this;
}
Expand Down Expand Up @@ -383,7 +383,7 @@ public CreateQueueOptions setMaxSizeInMegabytes(int maxSizeInMegabytes) {
*
* @return the requiresDuplicateDetection value.
*/
public boolean requiresDuplicateDetection() {
public boolean isDuplicateDetectionRequired() {
return this.requiresDuplicateDetection;
}

Expand All @@ -394,7 +394,7 @@ public boolean requiresDuplicateDetection() {
*
* @return the CreateQueueOptions object itself.
*/
public CreateQueueOptions setRequiresDuplicateDetection(boolean requiresDuplicateDetection) {
public CreateQueueOptions setDuplicateDetectionRequired(boolean requiresDuplicateDetection) {
this.requiresDuplicateDetection = requiresDuplicateDetection;
return this;
}
Expand All @@ -404,7 +404,7 @@ public CreateQueueOptions setRequiresDuplicateDetection(boolean requiresDuplicat
*
* @return the requiresSession value.
*/
public boolean requiresSession() {
public boolean isSessionRequired() {
return this.requiresSession;
}

Expand All @@ -415,7 +415,7 @@ public boolean requiresSession() {
*
* @return the CreateQueueOptions object itself.
*/
public CreateQueueOptions setRequiresSession(boolean requiresSession) {
public CreateQueueOptions setSessionRequired(boolean requiresSession) {
this.requiresSession = requiresSession;
return this;
}
Expand Down
24 changes: 12 additions & 12 deletions .../java/com/azure/messaging/servicebus/administration/models/CreateSubscriptionOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ public class CreateSubscriptionOptions {
* <li>{@link #setAutoDeleteOnIdle(Duration)} is max duration value.</li>
* <li>{@link #setDeadLetteringOnMessageExpiration(boolean)} is false.</li>
* <li>{@link #setDefaultMessageTimeToLive(Duration)} is max duration value.</li>
* <li>{@link #setEnableBatchedOperations(boolean)} is true.</li>
* <li>{@link #setBatchedOperationsEnabled(boolean)} is true.</li>
* <li>{@link #setEnableDeadLetteringOnFilterEvaluationExceptions(boolean)} is true.</li>
* <li>{@link #setLockDuration(Duration)} is 1 minute.</li>
* <li>{@link #setMaxDeliveryCount(int)} is 10.</li>
* <li>{@link #setRequiresSession(boolean)} is false.</li>
* <li>{@link #setSessionRequired(boolean)} is false.</li>
* <li>{@link #setStatus(EntityStatus)} is {@link EntityStatus#ACTIVE}.</li>
* </ul>
*
Expand Down Expand Up @@ -76,15 +76,15 @@ public CreateSubscriptionOptions(SubscriptionProperties subscription) {
Objects.requireNonNull(subscription, "'subscription' cannot be null.");

this.autoDeleteOnIdle = subscription.getAutoDeleteOnIdle();
this.deadLetteringOnMessageExpiration = subscription.deadLetteringOnMessageExpiration();
this.deadLetteringOnFilterEvaluationExceptions = subscription.enableDeadLetteringOnFilterEvaluationExceptions();
this.deadLetteringOnMessageExpiration = subscription.isDeadLetteringOnMessageExpiration();
this.deadLetteringOnFilterEvaluationExceptions = subscription.isDeadLetteringOnFilterEvaluationExceptions();
this.defaultMessageTimeToLive = subscription.getDefaultMessageTimeToLive();
this.enableBatchedOperations = subscription.enableBatchedOperations();
this.enableBatchedOperations = subscription.isBatchedOperationsEnabled();
this.forwardTo = subscription.getForwardTo();
this.forwardDeadLetteredMessagesTo = subscription.getForwardDeadLetteredMessagesTo();
this.lockDuration = subscription.getLockDuration();
this.maxDeliveryCount = subscription.getMaxDeliveryCount();
this.requiresSession = subscription.requiresSession();
this.requiresSession = subscription.isSessionRequired();
this.status = subscription.getStatus();
this.userMetadata = subscription.getUserMetadata();
}
Expand Down Expand Up @@ -119,7 +119,7 @@ public CreateSubscriptionOptions setLockDuration(Duration lockDuration) {
*
* @return the requiresSession value.
*/
public boolean requiresSession() {
public boolean isSessionRequired() {
return this.requiresSession;
}

Expand All @@ -130,7 +130,7 @@ public boolean requiresSession() {
*
* @return the CreateSubscriptionOptions object itself.
*/
public CreateSubscriptionOptions setRequiresSession(boolean requiresSession) {
public CreateSubscriptionOptions setSessionRequired(boolean requiresSession) {
this.requiresSession = requiresSession;
return this;
}
Expand Down Expand Up @@ -166,7 +166,7 @@ public CreateSubscriptionOptions setDefaultMessageTimeToLive(Duration defaultMes
*
* @return the deadLetteringOnMessageExpiration value.
*/
public boolean deadLetteringOnMessageExpiration() {
public boolean isDeadLetteringOnMessageExpiration() {
return this.deadLetteringOnMessageExpiration;
}

Expand All @@ -189,7 +189,7 @@ public CreateSubscriptionOptions setDeadLetteringOnMessageExpiration(boolean dea
*
* @return the deadLetteringOnFilterEvaluationExceptions value.
*/
public boolean enableDeadLetteringOnFilterEvaluationExceptions() {
public boolean isDeadLetteringOnFilterEvaluationExceptions() {
return this.deadLetteringOnFilterEvaluationExceptions;
}

Expand Down Expand Up @@ -236,7 +236,7 @@ public CreateSubscriptionOptions setMaxDeliveryCount(int maxDeliveryCount) {
*
* @return the enableBatchedOperations value.
*/
public boolean enableBatchedOperations() {
public boolean isBatchedOperationsEnabled() {
return this.enableBatchedOperations;
}

Expand All @@ -248,7 +248,7 @@ public boolean enableBatchedOperations() {
*
* @return the CreateSubscriptionOptions object itself.
*/
public CreateSubscriptionOptions setEnableBatchedOperations(boolean enableBatchedOperations) {
public CreateSubscriptionOptions setBatchedOperationsEnabled(boolean enableBatchedOperations) {
this.enableBatchedOperations = enableBatchedOperations;
return this;
}
Expand Down
32 changes: 16 additions & 16 deletions ...rc/main/java/com/azure/messaging/servicebus/administration/models/CreateTopicOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@ public class CreateTopicOptions {
* <li>{@link #setDefaultMessageTimeToLive(Duration)} is max duration value.</li>
* <li>{@link #setDuplicateDetectionHistoryTimeWindow(Duration)} is max duration value, but duplication
* detection is disabled.</li>
* <li>{@link #setRequiresDuplicateDetection(boolean)} is false.</li>
* <li>{@link #setEnableBatchedOperations(boolean)} is true.</li>
* <li>{@link #setDuplicateDetectionRequired(boolean)} is false.</li>
* <li>{@link #setBatchedOperationsEnabled(boolean)} (boolean)} is true.</li>
* <li>{@link #setLockDuration(Duration)} is 1 minute.</li>
* <li>{@link #setMaxDeliveryCount(int)} is 10.</li>
* <li>{@link #setMaxSizeInMegabytes(long)} is 1024MB.</li>
* <li>{@link #setRequiresSession(boolean)} is false.</li>
* <li>{@link #setSessionRequired(boolean)} is false.</li>
* <li>{@link #setStatus(EntityStatus)} is {@link EntityStatus#ACTIVE}.</li>
* </ul>
*
Expand Down Expand Up @@ -89,11 +89,11 @@ public CreateTopicOptions(TopicProperties topic) {
this.autoDeleteOnIdle = topic.getAutoDeleteOnIdle();
this.defaultMessageTimeToLive = topic.getDefaultMessageTimeToLive();
this.duplicateDetectionHistoryTimeWindow = topic.getDuplicateDetectionHistoryTimeWindow();
this.enableBatchedOperations = topic.enableBatchedOperations();
this.enablePartitioning = topic.enablePartitioning();
this.enableBatchedOperations = topic.isBatchedOperationsEnabled();
this.enablePartitioning = topic.isPartitioningEnabled();
this.maxSizeInMegabytes = topic.getMaxSizeInMegabytes();
this.requiresDuplicateDetection = topic.requiresDuplicateDetection();
this.supportOrdering = topic.supportOrdering();
this.requiresDuplicateDetection = topic.isDuplicateDetectionRequired();
this.supportOrdering = topic.isOrderingSupported();
this.status = topic.getStatus();
this.userMetadata = topic.getUserMetadata();
}
Expand Down Expand Up @@ -184,7 +184,7 @@ public CreateTopicOptions setDuplicateDetectionHistoryTimeWindow(Duration duplic
*
* @return the enableBatchedOperations value.
*/
public Boolean enableBatchedOperations() {
public Boolean isBatchedOperationsEnabled() {
return this.enableBatchedOperations;
}

Expand All @@ -196,7 +196,7 @@ public Boolean enableBatchedOperations() {
*
* @return the CreateTopicOptions object itself.
*/
public CreateTopicOptions setEnableBatchedOperations(boolean enableBatchedOperations) {
public CreateTopicOptions setBatchedOperationsEnabled(boolean enableBatchedOperations) {
this.enableBatchedOperations = enableBatchedOperations;
return this;
}
Expand All @@ -207,7 +207,7 @@ public CreateTopicOptions setEnableBatchedOperations(boolean enableBatchedOperat
*
* @return the enablePartitioning value.
*/
public Boolean enablePartitioning() {
public Boolean isPartitioningEnabled() {
return this.enablePartitioning;
}

Expand All @@ -219,7 +219,7 @@ public Boolean enablePartitioning() {
*
* @return the CreateTopicOptions object itself.
*/
public CreateTopicOptions setEnablePartitioning(boolean enablePartitioning) {
public CreateTopicOptions setPartitioningEnabled(boolean enablePartitioning) {
this.enablePartitioning = enablePartitioning;
return this;
}
Expand Down Expand Up @@ -263,7 +263,7 @@ public boolean isSupportOrdering() {
*
* @return the CreateTopicOptions object itself.
*/
public CreateTopicOptions setSupportOrdering(boolean supportOrdering) {
public CreateTopicOptions setOrderingSupported(boolean supportOrdering) {
this.supportOrdering = supportOrdering;
return this;
}
Expand Down Expand Up @@ -344,7 +344,7 @@ public CreateTopicOptions setMaxSizeInMegabytes(long maxSizeInMegabytes) {
*
* @return the requiresDuplicateDetection value.
*/
public Boolean requiresDuplicateDetection() {
public Boolean isDuplicateDetectionRequired() {
return this.requiresDuplicateDetection;
}

Expand All @@ -355,7 +355,7 @@ public Boolean requiresDuplicateDetection() {
*
* @return the CreateTopicOptions object itself.
*/
public CreateTopicOptions setRequiresDuplicateDetection(boolean requiresDuplicateDetection) {
public CreateTopicOptions setDuplicateDetectionRequired(boolean requiresDuplicateDetection) {
this.requiresDuplicateDetection = requiresDuplicateDetection;
return this;
}
Expand All @@ -365,7 +365,7 @@ public CreateTopicOptions setRequiresDuplicateDetection(boolean requiresDuplicat
*
* @return the requiresSession value.
*/
public Boolean requiresSession() {
public Boolean isSessionRequired() {
return this.requiresSession;
}

Expand All @@ -376,7 +376,7 @@ public Boolean requiresSession() {
*
* @return the CreateTopicOptions object itself.
*/
public CreateTopicOptions setRequiresSession(boolean requiresSession) {
public CreateTopicOptions setSessionRequired(boolean requiresSession) {
this.requiresSession = requiresSession;
return this;
}
Expand Down
Loading