Skip to content

azure-communication-administration - Regenerate Code for Updated Swagger #15861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waynemo merged 2 commits into from
Oct 1, 2020
Merged

azure-communication-administration - Regenerate Code for Updated Swagger #15861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f11ce9b
Update swagger and regenerate code
waynemo Oct 1, 2020
c0e5e45
Fix tests after code regeneration
waynemo Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...com/azure/communication/administration/implementation/PhoneNumberAdministrationsImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ Mono<Response<NumberConfigurationResponse>> getNumberConfiguration(
Context context);

@Patch("/administration/phonenumbers/numberconfiguration/configure")
@ExpectedResponses({202})
@ExpectedResponses({200})
@UnexpectedResponseExceptionType(ErrorResponseException.class)
Mono<Response<Void>> configureNumber(
@HostParam("endpoint") String endpoint,
Expand All @@ -149,7 +149,7 @@ Mono<Response<Void>> configureNumber(
Context context);

@Patch("/administration/phonenumbers/numberconfiguration/unconfigure")
@ExpectedResponses({202})
@ExpectedResponses({200})
@UnexpectedResponseExceptionType(ErrorResponseException.class)
Mono<Response<Void>> unconfigureNumber(
@HostParam("endpoint") String endpoint,
Expand Down
26 changes: 0 additions & 26 deletions ...ration/src/main/java/com/azure/communication/administration/models/PstnConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@ public final class PstnConfiguration {
@JsonProperty(value = "applicationId")
private String applicationId;

/*
* Routable TargetId for the ACS Number
*/
@JsonProperty(value = "azurePstnTargetId")
private String azurePstnTargetId;

/**
* Get the callbackUrl property: The webhook URL on the phone number configuration.
*
Expand Down Expand Up @@ -67,24 +61,4 @@ public PstnConfiguration setApplicationId(String applicationId) {
this.applicationId = applicationId;
return this;
}

/**
* Get the azurePstnTargetId property: Routable TargetId for the ACS Number.
*
* @return the azurePstnTargetId value.
*/
public String getAzurePstnTargetId() {
return this.azurePstnTargetId;
}

/**
* Set the azurePstnTargetId property: Routable TargetId for the ACS Number.
*
* @param azurePstnTargetId the azurePstnTargetId value to set.
* @return the PstnConfiguration object itself.
*/
public PstnConfiguration setAzurePstnTargetId(String azurePstnTargetId) {
this.azurePstnTargetId = azurePstnTargetId;
return this;
}
}
6 changes: 2 additions & 4 deletions ...st/java/com/azure/communication/administration/PhoneNumberAsyncClientIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,6 @@ public void configureNumber() {
PhoneNumber number = new PhoneNumber(PHONENUMBER_TO_CONFIGURE);
PstnConfiguration pstnConfiguration = new PstnConfiguration();
pstnConfiguration.setApplicationId("ApplicationId");
pstnConfiguration.setAzurePstnTargetId("AzurePstnTargetId");
pstnConfiguration.setCallbackUrl("https://callbackurl");

Mono<Void> mono = this.getClient().configureNumber(number, pstnConfiguration);
Expand All @@ -359,14 +358,13 @@ public void configureNumberWithResponse() {
PhoneNumber number = new PhoneNumber(PHONENUMBER_TO_CONFIGURE);
PstnConfiguration pstnConfiguration = new PstnConfiguration();
pstnConfiguration.setApplicationId("ApplicationId");
pstnConfiguration.setAzurePstnTargetId("AzurePstnTargetId");
pstnConfiguration.setCallbackUrl("https://callbackurl");

Mono<Response<Void>> mono = this.getClient().configureNumberWithResponse(number, pstnConfiguration, Context.NONE);

StepVerifier.create(mono)
.assertNext(item -> {
assertEquals(202, item.getStatusCode());
assertEquals(200, item.getStatusCode());
})
.verifyComplete();
}
Expand Down Expand Up @@ -416,7 +414,7 @@ public void unconfigureNumberWithResponse() {

StepVerifier.create(mono)
.assertNext(item -> {
assertEquals(202, item.getStatusCode());
assertEquals(200, item.getStatusCode());
})
.verifyComplete();
}
Expand Down
6 changes: 2 additions & 4 deletions ...rc/test/java/com/azure/communication/administration/PhoneNumberClientIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,6 @@ public void configureNumber() {
PhoneNumber number = new PhoneNumber(PHONENUMBER_TO_CONFIGURE);
PstnConfiguration pstnConfiguration = new PstnConfiguration();
pstnConfiguration.setApplicationId("ApplicationId");
pstnConfiguration.setAzurePstnTargetId("AzurePstnTargetId");
pstnConfiguration.setCallbackUrl("https://callbackurl");

this.getClient().configureNumber(number, pstnConfiguration);
Expand All @@ -275,12 +274,11 @@ public void configureNumberWithResponse() {
PhoneNumber number = new PhoneNumber(PHONENUMBER_TO_CONFIGURE);
PstnConfiguration pstnConfiguration = new PstnConfiguration();
pstnConfiguration.setApplicationId("ApplicationId");
pstnConfiguration.setAzurePstnTargetId("AzurePstnTargetId");
pstnConfiguration.setCallbackUrl("https://callbackurl");

Response<Void> response = this.getClient().configureNumberWithResponse(number, pstnConfiguration, Context.NONE);

assertEquals(202, response.getStatusCode());
assertEquals(200, response.getStatusCode());
}

@Test()
Expand Down Expand Up @@ -315,7 +313,7 @@ public void unconfigureNumberWithResponse() {

Response<Void> response = this.getClient().unconfigureNumberWithResponse(number, Context.NONE);

assertEquals(202, response.getStatusCode());
assertEquals(200, response.getStatusCode());
}

@Test()
Expand Down
2 changes: 1 addition & 1 deletion ...zure-communication-administration/src/test/resources/session-records/configureNumber.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"retry-after" : "0",
"X-Azure-Ref" : "0R3xpXwAAAADR0b9AJJ/fT4MZwVQ912XOWVZSMzBFREdFMDMwOQA5ZmM3YjUxOS1hOGNjLTRmODktOTM1ZS1jOTE0OGFlMDllODE=",
"Content-Length" : "0",
"StatusCode" : "202",
"StatusCode" : "200",
"Date" : "Tue, 22 Sep 2020 04:23:34 GMT"
},
"Exception" : null
Expand Down
2 changes: 1 addition & 1 deletion ...cation-administration/src/test/resources/session-records/configureNumberWithResponse.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"retry-after" : "0",
"X-Azure-Ref" : "0RXxpXwAAAAA/H8wY0GrvSaITi8Q5Mz9xWVZSMzBFREdFMDMwOQA5ZmM3YjUxOS1hOGNjLTRmODktOTM1ZS1jOTE0OGFlMDllODE=",
"Content-Length" : "0",
"StatusCode" : "202",
"StatusCode" : "200",
"Date" : "Tue, 22 Sep 2020 04:23:33 GMT"
},
"Exception" : null
Expand Down
2 changes: 1 addition & 1 deletion ...mmunication-administration/src/test/resources/session-records/getNumberConfiguration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"retry-after" : "0",
"X-Azure-Ref" : "0RXxpXwAAAAAip43zYy9hQKnfk3RZ1OJ6WVZSMzBFREdFMDMwOQA5ZmM3YjUxOS1hOGNjLTRmODktOTM1ZS1jOTE0OGFlMDllODE=",
"StatusCode" : "200",
"Body" : "{\"pstnConfiguration\":{\"callbackUrl\":\"https://callbackurl\",\"applicationId\":\"ApplicationId\",\"azurePstnTargetId\":\"AzurePstnTargetId\"}}",
"Body" : "{\"pstnConfiguration\":{\"callbackUrl\":\"https://callbackurl\",\"applicationId\":\"ApplicationId\"}}",
"Date" : "Tue, 22 Sep 2020 04:23:33 GMT",
"Content-Type" : "application/json; charset=utf-8"
},
Expand Down
2 changes: 1 addition & 1 deletion ...administration/src/test/resources/session-records/getNumberConfigurationWithResponse.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"retry-after" : "0",
"X-Azure-Ref" : "0RXxpXwAAAAAip43zYy9hQKnfk3RZ1OJ6WVZSMzBFREdFMDMwOQA5ZmM3YjUxOS1hOGNjLTRmODktOTM1ZS1jOTE0OGFlMDllODE=",
"StatusCode" : "200",
"Body" : "{\"pstnConfiguration\":{\"callbackUrl\":\"https://callbackurl\",\"applicationId\":\"ApplicationId\",\"azurePstnTargetId\":\"AzurePstnTargetId\"}}",
"Body" : "{\"pstnConfiguration\":{\"callbackUrl\":\"https://callbackurl\",\"applicationId\":\"ApplicationId\"}}",
"Date" : "Tue, 22 Sep 2020 04:23:33 GMT",
"Content-Type" : "application/json; charset=utf-8"
},
Expand Down
2 changes: 1 addition & 1 deletion ...re-communication-administration/src/test/resources/session-records/unconfigureNumber.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"retry-after" : "0",
"X-Azure-Ref" : "0SXxpXwAAAACzA2zcS3YsSbP9fYFrMoz/WVZSMzBFREdFMDMwOQA5ZmM3YjUxOS1hOGNjLTRmODktOTM1ZS1jOTE0OGFlMDllODE=",
"Content-Length" : "0",
"StatusCode" : "202",
"StatusCode" : "200",
"Date" : "Tue, 22 Sep 2020 04:23:36 GMT"
},
"Exception" : null
Expand Down
2 changes: 1 addition & 1 deletion ...tion-administration/src/test/resources/session-records/unconfigureNumberWithResponse.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"retry-after" : "0",
"X-Azure-Ref" : "0SXxpXwAAAACzA2zcS3YsSbP9fYFrMoz/WVZSMzBFREdFMDMwOQA5ZmM3YjUxOS1hOGNjLTRmODktOTM1ZS1jOTE0OGFlMDllODE=",
"Content-Length" : "0",
"StatusCode" : "202",
"StatusCode" : "200",
"Date" : "Tue, 22 Sep 2020 04:23:36 GMT"
},
"Exception" : null
Expand Down
Loading