Created classes for parsing certificates, keys and secrets identifiers. #15851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcolin7
requested review from
chlowell,
christothes,
g2vinay,
heaths and
sadasant
ghost
added
the
vcolin7
changed the title
|
Should we write tests for these parsers? |
Member
Author
@sadasant I saw some tests for these in .NET so I assumed so. |
|
@vcolin7 thank you! I'll ask you some last questions over team before I approve. Ping me if I don't ping you first. |
|
@vcolin7 thank you for reaching out to me! I believe the conversation helped us a lot. |
…dkeys" and "deletedsecrets").
g2vinay
reviewed
Oct 3, 2020
...main/java/com/azure/security/keyvault/certificates/models/KeyVaultCertificateIdentifier.java
Outdated
Show resolved
Hide resolved
...main/java/com/azure/security/keyvault/certificates/models/KeyVaultCertificateIdentifier.java
Outdated
Show resolved
Hide resolved
...yvault-keys/src/main/java/com/azure/security/keyvault/keys/models/KeyVaultKeyIdentifier.java
Outdated
Show resolved
Hide resolved
...yvault-keys/src/main/java/com/azure/security/keyvault/keys/models/KeyVaultKeyIdentifier.java
Outdated
Show resolved
Hide resolved
...crets/src/main/java/com/azure/security/keyvault/secrets/models/KeyVaultSecretIdentifier.java
Outdated
Show resolved
Hide resolved
...crets/src/main/java/com/azure/security/keyvault/secrets/models/KeyVaultSecretIdentifier.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8292.
I'm not sure if the Identifier classes should belong to the
modelpackage, but they're there for now. Had to duplicate some code because we don't have a shared package for Key Vault in Java.Will add unit tests soon.Done.