Add SNI support in Identity SDK#15561
Merged
g2vinay merged 8 commits intoAzure:masterfrom Oct 2, 2020
Merged
Conversation
ghost
added
the
g2vinay
commented
Sep 23, 2020
sdk/identity/azure-identity/pom.xml
Outdated
| <groupId>com.microsoft.azure</groupId> | ||
| <artifactId>msal4j</artifactId> | ||
| <version>1.6.2</version> <!-- {x-version-update;com.microsoft.azure:msal4j;external_dependency} --> | ||
| <version>1.7.0</version> <!-- {x-version-update;com.microsoft.azure:msal4j;external_dependency} --> |
Member
Author
There was a problem hiding this comment.
NOTE: I'll update the external_dep file before merging, as that will impact other libraries using MSAL too.
Currently, the scope of review is kept till Identity only.
jianghaolu
approved these changes
Sep 23, 2020
srnagar
approved these changes
Sep 23, 2020
Comment on lines
+122
to
+124
| new AuthenticationRecord(msalToken.getAuthenticationResult(), | ||
| identityClient.getTenantId(), identityClient.getClientId()), | ||
| msalToken.getAccount().getTenantProfiles())); |
Member
There was a problem hiding this comment.
nit: The formatting looks a bit odd. Probably moving the instantiation of AuthenticationRecord outside of set() would make it more readable too.
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClient.java
Show resolved
Hide resolved
...ity/azure-identity/src/main/java/com/azure/identity/implementation/util/CertificateUtil.java
Show resolved
Hide resolved
g2vinay
changed the title
schaabs
approved these changes
Sep 29, 2020
g2vinay
requested review from
JimSuplizio,
alzimmermsft,
chenrujun,
conniey,
danieljurek,
jialindai,
mitchdenny,
mssfang,
samvaity and
saragluna
as code owners
g2vinay
requested review from
YijunXieMS,
yiliuTo and
zhoufenqin
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates MSAL4J dependency to 1.7.1.
Accommodates the TenantProfiles added to
IAccountin MSAL4J.Adds Chained Certificate support to
ClientCertificateCredential.Adds option for user to configure sending x5c on
ClientCertificateCredentialBuilderFixes #10370