Skip to content

Conversation

@Soreloser2
Copy link
Contributor

Data is now a parameter in the constructor, and does not have a setter method. This more closely follows the Event Grid Event spec, which requires that data be set. However, there is no verification/null checking of the data on the SDK side.

Closes #14922

Data is now a parameter in the constructor, and does not have a setter method
@Soreloser2 Soreloser2 added Event Grid Client This issue points to a problem in the data-plane of the library. labels Sep 9, 2020
@Soreloser2 Soreloser2 added this to the [2020] October milestone Sep 9, 2020
@Soreloser2 Soreloser2 requested a review from bsiegel September 9, 2020 23:17
@Soreloser2 Soreloser2 self-assigned this Sep 9, 2020
@joshfree joshfree requested a review from YijunXieMS September 9, 2020 23:24
@Soreloser2 Soreloser2 mentioned this pull request Sep 11, 2020
11 tasks
@Soreloser2 Soreloser2 merged commit d43a520 into Azure:master Sep 11, 2020
@Soreloser2 Soreloser2 deleted the tsdahl/eventgrid branch September 11, 2020 23:12
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. Event Grid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change EventGridEvent to require data

2 participants