Force closes links when connection is closed so it requests another link.#14990
Merged
conniey merged 21 commits intoAzure:masterfrom Sep 10, 2020
Merged
Force closes links when connection is closed so it requests another link.#14990conniey merged 21 commits intoAzure:masterfrom
conniey merged 21 commits intoAzure:masterfrom
Conversation
conniey
requested review from
YijunXieMS,
alzimmermsft,
anuchandy,
hemanttanwar,
jianghaolu,
mssfang and
srnagar
as code owners
ghost
added
conniey
force-pushed
the
amqp-core-amqp-issue
branch
from
091b1f3 to
1b10fd5
Compare
conniey
force-pushed
the
amqp-core-amqp-issue
branch
from
87b774c to
3ecd439
Compare
srnagar
approved these changes
Sep 10, 2020
...re-amqp/src/test/java/com/azure/core/amqp/implementation/handler/ReceiveLinkHandlerTest.java
Outdated
Show resolved
Hide resolved
...core/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/ReactorConnection.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/ReactorReceiver.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/ReactorSender.java
Outdated
Show resolved
Hide resolved
.../azure-core-amqp/src/test/java/com/azure/core/amqp/implementation/ReactorConnectionTest.java
Outdated
Show resolved
Hide resolved
…tting one terminal state.
conniey
force-pushed
the
amqp-core-amqp-issue
branch
from
3ecd439 to
5052391
Compare
conniey
force-pushed
the
amqp-core-amqp-issue
branch
from
5052391 to
7c75c65
Compare
conniey
added a commit
to conniey/azure-sdk-for-java
that referenced
this pull request
Sep 11, 2020
…ink. (Azure#14990) * Fixing the string format for Dispatch task. * Cleaning up print statements. * Updating text in README.md * Remove getErrors() which overlaps with getEndpointStates(). Only ouputting one terminal state. * Clean up tests and use subscribeWith. * Locally closing on connection error. * Add changelog entry
conniey
added a commit
that referenced
this pull request
Sep 11, 2020
* SB Track2: Expose AMQP details ServiceBus Messages for sending and receiving. (#14848) Expose AMQP details ServiceBus Messages for sending and receiving. * Force closes links when connection is closed so it requests another link. (#14990) * Fixing the string format for Dispatch task. * Cleaning up print statements. * Updating text in README.md * Remove getErrors() which overlaps with getEndpointStates(). Only ouputting one terminal state. * Clean up tests and use subscribeWith. * Locally closing on connection error. * Add changelog entry * Update versions. * Update versions for service bus and event hubs * Update CHANGELOG.md Update the date on CHANGELOG Co-authored-by: Hemant Tanwar <hemant_tanwar@hotmail.com>
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jun 25, 2021
[Python] track2 config (Azure#14990) * authorization * automation * recoveryservices * logic * notificationhubs * search
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jun 25, 2021
[Python] track2 config (Azure#14990) * authorization * automation * recoveryservices * logic * notificationhubs * search
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jun 25, 2021
[Python] track2 config (Azure#14990) * authorization * automation * recoveryservices * logic * notificationhubs * search
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-java
that referenced
this pull request
Jun 25, 2021
[Python] track2 config (Azure#14990) * authorization * automation * recoveryservices * logic * notificationhubs * search
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug where we try to reopen the connection, but there are no downstream subscribers because the first receive link has not received a terminal signal yet. Consequently, another "amqp:connection:forced" error is propagated due to idle links, and the cycle continues.
Fixes: #13785, #13420, #13924