Skip to content

Conversation

@azabbasi
Copy link
Contributor

image

Copy link
Contributor

@bikamani bikamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see models twice in your snapshot?

@azabbasi
Copy link
Contributor Author

I see models twice in your snapshot?

yes, the one you see at the root will be the folder we use for overriding models.

@azabbasi
Copy link
Contributor Author

I see models twice in your snapshot?

yes, the one you see at the root will be the folder we use for overriding models.

https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/formrecognizer/azure-ai-formrecognizer/src/main/java/com/azure/ai/formrecognizer
as an example.

Copy link
Member

@abhipsaMisra abhipsaMisra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to have lost some Query specific files, are they a part of some other files now?

@azabbasi
Copy link
Contributor Author

We seem to have lost some Query specific files, are they a part of some other files now?

Are you talking about the QueriesImpl file?

@azabbasi
Copy link
Contributor Author

image

@abhipsaMisra
Copy link
Member

We seem to have lost some Query specific files, are they a part of some other files now?

Are you talking about the QueriesImpl file?

Yeah, the refactoring is probably not showing up properly on GitHub. It listed a couple of query files as deleted (instead of moved), so that threw me off. The files look good.

@azabbasi azabbasi merged commit 18e6ea8 into master Aug 25, 2020
@azabbasi azabbasi deleted the feature/adt/azabbasi/folderstructure branch August 25, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants