-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Use msiexec to install Cosmos emulator. #13405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
weshaggard
merged 5 commits into
Azure:master
from
mitchdenny:fix-cosmosdb-emulator-downloads
Jul 22, 2020
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
da0257c
Use msiexec to install Cosmos emulator.
mitchdenny 7ac0aef
Update start parameters.
mitchdenny 9520499
Use PowerShell options.
mitchdenny 42734b9
Duplicate -NoUI switch.
mitchdenny 6b9c0dd
Try a 10 minute timeout for emulator start-up.
mitchdenny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| parameters: | ||
| EmulatorMsiUrl: "https://aka.ms/cosmosdb-emulator" | ||
| StartParameters: '' | ||
|
|
||
| steps: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We already have the template in the tools repo see https://github.com/Azure/azure-sdk-tools/blob/master/eng/pipelines/templates/steps/cosmos-emulator.yml. We can either reference it directly or move it under eng/common. |
||
| - powershell: | | ||
| $targetDir = $env:temp | ||
| Write-Host "Downloading and extracting Cosmos DB Emulator - ${{ parameters.EmulatorMsiUrl }}" | ||
| Write-Host "Target Dir: $targetDir" | ||
| msiexec /a ${{ parameters.EmulatorMsiUrl }} TARGETDIR=$targetDir /qn | wait-process | ||
| displayName: Download and Extract Public Cosmos DB Emulator | ||
| - powershell: | | ||
| Write-Host "Launching Cosmos DB Emulator" | ||
| Import-Module "$env:temp\Azure Cosmos DB Emulator\PSModules\Microsoft.Azure.CosmosDB.Emulator" | ||
| Start-CosmosDbEmulator -NoUI ${{ parameters.StartParameters }} | ||
| displayName: Start Cosmos DB Emulator | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have start parameters like the above mentioned ones...
"/DisableRateLimiting /PartitionCount=100 /Consistency=Strong"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added them into the calling template:
/NoExplorer /NoUI /DisableRateLimiting /PartitionCount=100 /Consistency=StrongThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read through the implementation of the module. The
/NoExploreroption is on by default, and/DisableRateLimitingis also the default in the PowerShell cmdlet. These changes should do the trick. I'll verify it runs green and then merge.