Fix spring builds with CHANGELOG#13394
Closed
mitchdenny wants to merge 3 commits intoAzure:masterfrom
Closed
Conversation
mitchdenny
requested review from
chenrujun,
danieljurek,
jialindai,
saragluna,
yiliuTo and
zhoufenqin
as code owners
mitchdenny
added
EngSys
Contributor
Author
|
@Azure/azure-sdk-write-spring just a heads up that I am merging this in because it was the cause of some failed builds overnight. |
Contributor
Author
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Thanks for adding these files. I also added these files in another PR yesterday since the build couldn't pass otherwise. Since that PR is approved now so I suggest we close this PR. #12581. |
Contributor
Author
|
Thanks @saragluna .... closing this one. |
Member
|
Sorry for the late notice, I'll trigger the Spring live test pipeline against the master branch to see if it could pass now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a recent change in the
azure-client-sdk-parentPOM file we now need both aREADME.mdandCHANGELOG.mdfile in each module directory. In the case of test modules that are not going to be released they'll just be static. Doing this is easier that complex properties to control theskipAttachproperty in the parent POM (and having both aREADME.mdandCHANGELOG.mdis not such a bad idea on a per-module basis).