Skip to content

Consolidate behavior of options #13339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gapra-msft merged 3 commits into from
Jul 20, 2020
Merged

Consolidate behavior of options #13339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d969b53
Consolidate options to throw on null for required params and not thro…
gapra-msft Jul 20, 2020
cb403c2
Removed null check
gapra-msft Jul 20, 2020
17ac723
Removed import
gapra-msft Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...re-storage-blob/src/main/java/com/azure/storage/blob/specialized/BlobAsyncClientBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1374,7 +1374,7 @@ public Mono<Response<Map<String, String>>> getTagsWithResponse(BlobGetTagsOption
}

Mono<Response<Map<String, String>>> getTagsWithResponse(BlobGetTagsOptions options, Context context) {
StorageImplUtils.assertNotNull("options", options);
options = (options == null) ? new BlobGetTagsOptions() : options;
BlobRequestConditions requestConditions = (options.getRequestConditions() == null)
? new BlobRequestConditions() : options.getRequestConditions();
return this.azureBlobStorage.blobs().getTagsWithRestResponseAsync(null, null, null, null, snapshot,
Expand Down
6 changes: 3 additions & 3 deletions ...e-storage-blob/src/main/java/com/azure/storage/blob/specialized/BlobLeaseAsyncClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ public Mono<Response<String>> renewLeaseWithResponse(BlobRenewLeaseOptions optio
}

Mono<Response<String>> renewLeaseWithResponse(BlobRenewLeaseOptions options, Context context) {
StorageImplUtils.assertNotNull("options", options);
options = (options == null) ? new BlobRenewLeaseOptions() : options;
BlobLeaseRequestConditions requestConditions = (options.getRequestConditions() == null)
? new BlobLeaseRequestConditions() : options.getRequestConditions();
context = context == null ? Context.NONE : context;
Expand Down Expand Up @@ -321,7 +321,7 @@ public Mono<Response<Void>> releaseLeaseWithResponse(BlobReleaseLeaseOptions opt
}

Mono<Response<Void>> releaseLeaseWithResponse(BlobReleaseLeaseOptions options, Context context) {
StorageImplUtils.assertNotNull("options", options);
options = (options == null) ? new BlobReleaseLeaseOptions() : options;
BlobLeaseRequestConditions requestConditions = (options.getRequestConditions() == null)
? new BlobLeaseRequestConditions() : options.getRequestConditions();
context = context == null ? Context.NONE : context;
Expand Down Expand Up @@ -414,7 +414,7 @@ public Mono<Response<Integer>> breakLeaseWithResponse(BlobBreakLeaseOptions opti
}

Mono<Response<Integer>> breakLeaseWithResponse(BlobBreakLeaseOptions options, Context context) {
StorageImplUtils.assertNotNull("options", options);
options = (options == null) ? new BlobBreakLeaseOptions() : options;
BlobLeaseRequestConditions requestConditions = (options.getRequestConditions() == null)
? new BlobLeaseRequestConditions() : options.getRequestConditions();
context = context == null ? Context.NONE : context;
Expand Down