Skip to content

mgmt, prepare for shared SerializerAdapter #13320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weidongxu-microsoft merged 2 commits into from
Jul 20, 2020
Merged

mgmt, prepare for shared SerializerAdapter #13320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47e8044
prepare for shared SerializerAdapter
weidongxu-microsoft Jul 17, 2020
2e26af8
fix checkstyle
weidongxu-microsoft Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ...mgmt/src/main/java/com/azure/resourcemanager/resources/fluentcore/AzureServiceClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,27 @@ public abstract class AzureServiceClient {
SDK_VERSION = PROPERTIES.getOrDefault("version", "UnknownVersion");
}

private final SerializerAdapter serializerAdapter = new AzureJacksonAdapter();
private final SerializerAdapter serializerAdapter;

private final String sdkName;

protected AzureServiceClient(HttpPipeline httpPipeline, AzureEnvironment environment) {
sdkName = this.getClass().getPackage().getName();

this.serializerAdapter = new AzureJacksonAdapter();
((AzureJacksonAdapter) serializerAdapter).serializer().registerModule(DateTimeDeserializer.getModule());
}

protected AzureServiceClient(HttpPipeline httpPipeline, SerializerAdapter serializerAdapter,
AzureEnvironment environment) {
sdkName = this.getClass().getPackage().getName();

this.serializerAdapter = serializerAdapter;
if (serializerAdapter instanceof AzureJacksonAdapter) {
((AzureJacksonAdapter) serializerAdapter).serializer().registerModule(DateTimeDeserializer.getModule());
Copy link
Member Author

@weidongxu-microsoft weidongxu-microsoft Jul 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try move DateTimeDeserializer to azure-core-mgmt in beta.3

}
}

/**
* Gets serializer adapter for JSON serialization/de-serialization.
*
Expand Down