mgmt, proof of concept, patch test-jar to module#12864
Closed
weidongxu-microsoft wants to merge 2 commits intoAzure:masterfrom
Closed
mgmt, proof of concept, patch test-jar to module#12864weidongxu-microsoft wants to merge 2 commits intoAzure:masterfrom
weidongxu-microsoft wants to merge 2 commits intoAzure:masterfrom
Conversation
| package com.azure.resourcemanager.resources.core; | ||
|
|
||
| import com.azure.core.credential.TokenCredential; | ||
| import com.azure.core.implementation.TypeUtil; |
Member
Author
There was a problem hiding this comment.
Please try find time to remove dependency on implementation package.
Comment on lines
+142
to
+145
| --patch-module com.azure.resourcemanager.resources=../../resources/mgmt/target/test-classes | ||
| --add-opens com.azure.resourcemanager.resources/com.azure.resourcemanager.resources.core=com.fasterxml.jackson.databind,com.azure.core | ||
| --add-exports com.azure.resourcemanager.resources/com.azure.resourcemanager.resources.core=ALL-UNNAMED,com.azure.resourcemanager.authorization | ||
| --add-reads com.azure.resourcemanager.resources=ALL-UNNAMED |
Member
Author
There was a problem hiding this comment.
Black magic here...
It patches test-jar into the resources module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On this, I can run playback on resources and authorization modules.
Also need this #12863