Skip to content

mgmt, core, open to azure-core, for f.setAccessible(true); in FlatteningSerializer #12863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weidongxu-microsoft merged 1 commit into from
Jul 8, 2020
Merged

mgmt, core, open to azure-core, for f.setAccessible(true); in FlatteningSerializer #12863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions sdk/core/azure-core-management/src/main/java/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,14 @@
exports com.azure.core.management.serializer;
exports com.azure.core.management.exception;

opens com.azure.core.management to com.fasterxml.jackson.databind;
opens com.azure.core.management.exception to com.fasterxml.jackson.databind;
opens com.azure.core.management.implementation.polling to com.fasterxml.jackson.databind;
opens com.azure.core.management to
com.fasterxml.jackson.databind,
com.azure.core;
opens com.azure.core.management.exception to
Copy link
Contributor

@xseeseesee xseeseesee Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which class in com.azure.core.management.exception requires this change?

Copy link
Member Author

@weidongxu-microsoft weidongxu-microsoft Jul 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On core-mgmt level, I am not able to predict which of subclass of ManagementError would have JsonFlatten. It is out of control of core-mgmt lib. But if anyone uses a subclass of it with JsonFlatten, you now need open to azure-core, here in core-mgmt.

com.fasterxml.jackson.databind,
com.azure.core;
opens com.azure.core.management.implementation.polling to
com.fasterxml.jackson.databind;

uses com.azure.core.http.HttpClientProvider;
}