Skip to content

Fixes bug in buffered upload #12832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gapra-msft merged 1 commit into from
Jul 7, 2020
Merged

Fixes bug in buffered upload #12832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...torage-common/src/main/java/com/azure/storage/common/implementation/UploadBufferPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,11 @@ public Flux<BufferAggregator> write(ByteBuffer buf) {
// We will overflow the current buffer and require another one.
// Duplicate and adjust the window of buf so that we fill up currentBuf without going out of bounds.
ByteBuffer duplicate = buf.duplicate();
duplicate.limit(buf.position() + (int) this.currentBuf.remainingCapacity());
int newLimit = buf.position() + (int) this.currentBuf.remainingCapacity();
duplicate.limit(newLimit);
this.currentBuf.append(duplicate);
// Adjust the window of original buffer to represent remaining part.
buf.position(buf.position() + (int) this.currentBuf.remainingCapacity());
buf.position(newLimit);

result = Flux.just(this.currentBuf);

Expand Down