Skip to content

change RNTBD defaults as per learning and to be in par with .Net #12654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moderakh merged 2 commits into from
Jul 7, 2020
Merged

change RNTBD defaults as per learning and to be in par with .Net #12654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a21898
change RNTBD defaults as per learning from customer
moderakh Jun 30, 2020
f06f738
reduced idle value to 1h
moderakh Jun 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/DirectConnectionConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
*/
public final class DirectConnectionConfig {
// Constants
private static final Duration DEFAULT_IDLE_ENDPOINT_TIMEOUT = Duration.ofSeconds(70L);
private static final Duration DEFAULT_CONNECT_TIMEOUT = Duration.ofSeconds(60L);
private static final Duration DEFAULT_IDLE_ENDPOINT_TIMEOUT = Duration.ofHours(1l);
private static final Duration DEFAULT_CONNECT_TIMEOUT = Duration.ofSeconds(5L);
Copy link

@David-Noble-at-work David-Noble-at-work Jun 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

private static final Duration DEFAULT_REQUEST_TIMEOUT = Duration.ofSeconds(5L);
private static final int DEFAULT_MAX_CONNECTIONS_PER_ENDPOINT = 130;
private static final int DEFAULT_MAX_REQUESTS_PER_CONNECTION = 30;
Expand Down Expand Up @@ -55,7 +55,7 @@ public static DirectConnectionConfig getDefaultConfig() {
*
* Configures timeout for underlying Netty Channel {@link ChannelOption#CONNECT_TIMEOUT_MILLIS}
*
* By default, the connect timeout is 60 seconds.
* By default, the connect timeout is 5 seconds.
*
* @return direct connect timeout
*/
Expand All @@ -69,7 +69,7 @@ public Duration getConnectTimeout() {
*
* Configures timeout for underlying Netty Channel {@link ChannelOption#CONNECT_TIMEOUT_MILLIS}
*
* By default, the connect timeout is 60 seconds.
* By default, the connect timeout is 5 seconds.
*
* @param connectTimeout the connection timeout
* @return the {@link DirectConnectionConfig}
Expand Down Expand Up @@ -112,7 +112,7 @@ public DirectConnectionConfig setIdleConnectionTimeout(Duration idleConnectionTi
/**
* Gets the idle endpoint timeout
*
* Default value is 70 seconds.
* Default value is 1 hour.
*
* If there are no requests to a specific endpoint for idle endpoint timeout duration,
* direct client closes all connections to that endpoint to save resources and I/O cost.
Expand All @@ -126,7 +126,7 @@ public Duration getIdleEndpointTimeout() {
/**
* Sets the idle endpoint timeout
*
* Default value is 70 seconds.
* Default value is 1 hour.
*
* If there are no requests to a specific endpoint for idle endpoint timeout duration,
* direct client closes all connections to that endpoint to save resources and I/O cost.
Expand Down