mgmt, support begin operation with syncpoll #12141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
248
to
251
| while (pollResponse.getStatus() != LongRunningOperationStatus.SUCCESSFULLY_COMPLETED) { | ||
| SdkContext.sleep(1000); | ||
| pollResponse = acceptedDeployment.getSyncPoller().poll(); | ||
| } |
Member
Author
There was a problem hiding this comment.
Support polling by user.
weidongxu-microsoft
requested review from
ChenTanyi,
nickzhums,
xseeseesee and
yungezz
| * | ||
| * @return the final result. | ||
| */ | ||
| T getFinalResult(); |
Member
Author
There was a problem hiding this comment.
Plan is to make this call return the resource, after LRO and after all following-up operations finished.
| } | ||
|
|
||
| @Override | ||
| public PollResponse<Void> poll() { |
Member
Author
There was a problem hiding this comment.
Next plan is to give a concrete class for this current Void in PollResponse, to provide more information about the poll, e.g. poll url, response body, etc.
But that would require more changes in core-management, so it would likely be delayed to another PR.
weidongxu-microsoft
changed the title
weidongxu-microsoft
requested review from
JonathanGiles,
anuchandy and
hemanttanwar
as code owners
ChenTanyi
approved these changes
Jun 23, 2020
.../mgmt/src/main/java/com/azure/resourcemanager/compute/implementation/VirtualMachineImpl.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, try replace
Deployment.beginCreateandResourceGroups.beginDeletewith this approach.Note that there is case which is much more complicated than this, those with dependency resources need to be created before LRO, and following-up operation after LRO.