-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Implemented ORS List Blobs #11756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
gapra-msft
wants to merge
5
commits into
Azure:feature/storage/stg73
from
gapra-msft:storage/orsListBlobs
Closed
Implemented ORS List Blobs #11756
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e163997
Added updated swagger change
gapra-msft 41b30e5
Changed keyset to entryset
gapra-msft a091405
Changed one comment
gapra-msft f759639
Merge branch 'feature/storage/stg73' into storage/orsListBlobs
gapra-msft 8b22a96
modified it to return null in emptu set case
gapra-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
43 changes: 31 additions & 12 deletions
43
...ure-storage-blob/src/main/java/com/azure/storage/blob/implementation/AppendBlobsImpl.java
Large diffs are not rendered by default.
Oops, something went wrong.
211 changes: 151 additions & 60 deletions
211
...age/azure-storage-blob/src/main/java/com/azure/storage/blob/implementation/BlobsImpl.java
Large diffs are not rendered by default.
Oops, something went wrong.
43 changes: 31 additions & 12 deletions
43
...zure-storage-blob/src/main/java/com/azure/storage/blob/implementation/BlockBlobsImpl.java
Large diffs are not rendered by default.
Oops, something went wrong.
71 changes: 51 additions & 20 deletions
71
...azure-storage-blob/src/main/java/com/azure/storage/blob/implementation/PageBlobsImpl.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
.../src/main/java/com/azure/storage/blob/implementation/models/ModifiedAccessConditions.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| // Code generated by Microsoft (R) AutoRest Code Generator. | ||
|
|
||
| package com.azure.storage.blob.implementation.models; | ||
|
|
||
| import com.azure.core.annotation.Fluent; | ||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlRootElement; | ||
|
|
||
| /** | ||
| * Additional parameters for a set of operations. | ||
| */ | ||
| @JacksonXmlRootElement(localName = "modified-access-conditions") | ||
| @Fluent | ||
| public final class ModifiedAccessConditions { | ||
| /* | ||
| * Specify a SQL where clause on blob tags to operate only on blobs with a | ||
| * matching value. | ||
| */ | ||
| @JsonProperty(value = "ifTags") | ||
| private String ifTags; | ||
|
|
||
| /** | ||
| * Get the ifTags property: Specify a SQL where clause on blob tags to | ||
| * operate only on blobs with a matching value. | ||
| * | ||
| * @return the ifTags value. | ||
| */ | ||
| public String getIfTags() { | ||
| return this.ifTags; | ||
| } | ||
|
|
||
| /** | ||
| * Set the ifTags property: Specify a SQL where clause on blob tags to | ||
| * operate only on blobs with a matching value. | ||
| * | ||
| * @param ifTags the ifTags value to set. | ||
| * @return the ModifiedAccessConditions object itself. | ||
| */ | ||
| public ModifiedAccessConditions setIfTags(String ifTags) { | ||
| this.ifTags = ifTags; | ||
| return this; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to find new home. We need to decouple model from "implementation model" per APIView feedback.
Anyway, it's a good practice to NOT place such logic inside constructors. BlobItem should ideally be plain data structure and this logic should move to some "transformer/mapper".