Skip to content

feat: update arm parent dependency #11582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChenTanyi merged 1 commit into from
Jun 1, 2020
Merged

feat: update arm parent dependency #11582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/mgmt/gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ var changePom = function(project) {
var modulePom = path.join(projectRoot, mod, 'pom.xml');
if (fs.existsSync(modulePom)) {
var pomContent = fs.readFileSync(modulePom, {encoding: 'utf-8'});
pomContent = pomContent.replace('<version>1.1.0</version>', '<version>1.3.0</version>');
pomContent = pomContent.replace('<version>1.1.0</version>', '<version>1.3.1</version>');
pomContent = pomContent.replace('<relativePath>../../../pom.management.xml</relativePath>', '<relativePath>../../parents/azure-arm-parent/pom.xml</relativePath>');
fs.writeFileSync(modulePom, pomContent, {encoding: 'utf-8'});
}
Expand Down
14 changes: 6 additions & 8 deletions sdk/parents/azure-arm-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.microsoft.azure</groupId>
<version>1.3.0</version>
<version>1.3.1</version>
Copy link
Contributor

@xseeseesee xseeseesee May 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who would help release 1.3.1?

Copy link
Contributor Author

@ChenTanyi ChenTanyi Jun 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would release after it merge.

<artifactId>azure-arm-parent</artifactId>
<packaging>pom</packaging>

Expand Down Expand Up @@ -41,7 +41,7 @@
<!-- Dependency Versions -->
<jackson.version>2.10.0</jackson.version>
<jackson-databind.version>2.10.0</jackson-databind.version>
<client-runtime.version>1.7.1</client-runtime.version>
<client-runtime.version>1.7.4</client-runtime.version>
<commons-codec.version>1.13</commons-codec.version>
<spotbugs.version>4.0.0-beta3</spotbugs.version>
<spotbugs.maven.version>3.1.12.2</spotbugs.maven.version>
Expand Down Expand Up @@ -634,8 +634,7 @@
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>${spotbugs.version}</version>
<!-- TODO: skip as it's failing -->
<version>${spotbugs.maven.version}</version>
<executions>
<execution>
<phase>none</phase>
Expand All @@ -645,7 +644,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<!-- TODO: skip as it's failing -->
<version>${maven-checkstyle-plugin.version}</version>
<executions>
<execution>
<phase>none</phase>
Expand Down Expand Up @@ -694,8 +693,7 @@
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>${spotbugs.version}</version>
<!-- TODO: skip as it's failing -->
<version>${spotbugs.maven.version}</version>
<executions>
<execution>
<phase>none</phase>
Expand All @@ -705,7 +703,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<!-- TODO: skip as it's failing -->
<version>${maven-checkstyle-plugin.version}</version>
<executions>
<execution>
<phase>none</phase>
Expand Down