Skip to content

Misc fixes for cosmos public surface APIs #11262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kushagraThapar merged 2 commits into from
May 19, 2020
Merged

Misc fixes for cosmos public surface APIs #11262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbbebc5
Misc fixes for cosmos public surface APIs
kushagraThapar May 18, 2020
fe5773d
Added constant for warning annotation message
kushagraThapar May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/code-quality-reports/src/main/resources/spotbugs/spotbugs-exclude.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1223,7 +1223,7 @@
<!-- Bug: https://github.com/Azure/azure-sdk-for-java/issues/9088 -->
<Match>
<Class name="com.azure.cosmos.CosmosClientException"/>
<Field name="cosmosResponseDiagnostics"/>
<Field name="cosmosDiagnostics"/>
<Bug pattern="SE_BAD_FIELD"/>
</Match>

Expand Down
2 changes: 1 addition & 1 deletion ...osmos-benchmark/src/main/java/com/azure/cosmos/benchmark/AsynReadWithMultipleClients.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ private void createClients() {
.endpoint(endpoint)
.key(key)
.consistencyLevel(configuration.getConsistencyLevel())
.connectionReuseAcrossClientsEnabled(true)
.connectionSharingAcrossClientsEnabled(true)
.contentResponseOnWriteEnabled(Boolean.parseBoolean(configuration.isContentResponseOnWriteEnabled()));
if (this.configuration.getConnectionMode().equals(ConnectionMode.DIRECT)) {
cosmosClientBuilder = cosmosClientBuilder.directMode(DirectConnectionConfig.getDefaultConfig());
Expand Down
9 changes: 6 additions & 3 deletions ...smos-examples/src/test/java/com/azure/cosmos/rx/examples/StoredProcedureAsyncAPITest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public void scriptConsoleLogEnabled() throws Exception {
final CountDownLatch successfulCompletionLatch = new CountDownLatch(1);

// Execute the stored procedure
client.executeStoredProcedure(getSprocLink(storedProcedure), requestOptions, new Object[]{})
client.executeStoredProcedure(getSprocLink(storedProcedure), requestOptions, new ArrayList<>())
.subscribe(storedProcedureResponse -> {
String logResult = "The value of x is 1.";
try {
Expand Down Expand Up @@ -154,7 +154,9 @@ public void executeStoredProcWithArgs() throws Exception {
final CountDownLatch successfulCompletionLatch = new CountDownLatch(1);

// Execute the stored procedure
Object[] storedProcedureArgs = new Object[]{"a", 123};
List<Object> storedProcedureArgs = new ArrayList<>();
storedProcedureArgs.add("a");
storedProcedureArgs.add(123);
client.executeStoredProcedure(getSprocLink(storedProcedure), requestOptions, storedProcedureArgs)
.subscribe(storedProcedureResponse -> {
String storedProcResultAsString = storedProcedureResponse.getResponseAsString();
Expand Down Expand Up @@ -200,7 +202,8 @@ class SamplePojo {
SamplePojo samplePojo = new SamplePojo();

// Execute the stored procedure
Object[] storedProcedureArgs = new Object[]{samplePojo};
List<Object> storedProcedureArgs = new ArrayList<>();
storedProcedureArgs.add(samplePojo);
client.executeStoredProcedure(getSprocLink(storedProcedure), requestOptions, storedProcedureArgs)
.subscribe(storedProcedureResponse -> {
String storedProcResultAsString = storedProcedureResponse.getResponseAsString();
Expand Down
22 changes: 0 additions & 22 deletions sdk/cosmos/azure-cosmos/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,31 +125,9 @@ Licensed under the MIT License.
<groupId>io.netty</groupId>
<artifactId>*</artifactId>
</exclusion>
<exclusion>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>*</artifactId>
</exclusion>
</exclusions>
</dependency>

<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.10.1</version> <!-- {x-version-update;com.fasterxml.jackson.core:jackson-core;external_dependency} -->
</dependency>

<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>2.10.1</version> <!-- {x-version-update;com.fasterxml.jackson.core:jackson-databind;external_dependency} -->
</dependency>

<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<version>2.10.1</version> <!-- {x-version-update;com.fasterxml.jackson.core:jackson-annotations;external_dependency} -->
</dependency>

<dependency>
<groupId>com.fasterxml.jackson.module</groupId>
<artifactId>jackson-module-afterburner</artifactId>
Expand Down
Loading