Skip to content

Generate LUIS authoring with latest swagger#11152

Merged
jianghaolu merged 3 commits intoAzure:masterfrom
jianghaolu:luisauthoring
May 14, 2020
Merged

Generate LUIS authoring with latest swagger#11152
jianghaolu merged 3 commits intoAzure:masterfrom
jianghaolu:luisauthoring

Conversation

@jianghaolu
Copy link
Contributor

No description provided.

Copy link
Contributor

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't correct.
The version in version_data.txt
com.microsoft.azure.cognitiveservices:azure-cognitiveservices-luis-authoring
1.0.4-beta is not a correct version. All beta versions must be in the form -beta.X (Note the period. after beta before the number). Further, the version in here and the version in the pom file don't even match. You've got 1.0.4 in here and 1.0.3 in the pom file which means that the tooling wasn't used to update the pom file. Please look at the versions and versioning in the contributing.md file.

The released version of this library is 1.0.2 which means this should be 1.0.3 if it's a dot version.
com.microsoft.azure.cognitiveservices:azure-cognitiveservices-luis-authoring;1.0.3-beta.1;1.0.3-beta1

Copy link
Contributor

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't of the correct format, nor is it what I'd asked for. 1.0.3-beta should be 1.0.3-beta.1
The entry in version_data.txt should be
com.microsoft.azure.cognitiveservices:azure-cognitiveservices-luis-authoring;1.0.3-beta.1;1.0.3-beta.1

I realize that the version released in 2018 is 1.0.2-beta but we've revised what versions need to be in 2019 and that needs to be followed.

@jianghaolu
Copy link
Contributor Author

Thanks @JimSuplizio for taking a look. The 1.0.4-beta was for computer vision which I was working on at the same time and got mixed. Sorry for the confusion.

I really want to adapt to the new versioning schemes too but unfortunately we've gone down the path of using the less than ideal versioning since 2018, as you noticed, for a few versions now. And this is the versioning scheme not only for LUIS authoring, but another dozen cognitive services. Having this one library, and this one version being different doesn't feel very user-friendly.

Also this is Track 1 library. Talked to @JonathanGiles and he is also leaning towards keeping Track 1 as is for now. We are versioning our Track 2 cognitive service libraries in the correct versioning scheme: https://repo1.maven.org/maven2/com/azure/azure-ai-textanalytics/, and coincidently this differentiates well from these auto-generated Track 1 libraries.

@jianghaolu
Copy link
Contributor Author

jianghaolu commented May 14, 2020

TBH once in a while I receive a request to release one of the cognitive services Track 1 SDKs. Though they only have to click their mouse a couple times to request a release, it's a PITA for me as I have to use a generator from someone's GitHub fork who left the team couple years ago that only runs on a specific AutoRest & Node version, and apply a bunch of manual fixes, and being ashamed of why in the world I'm releasing these ugly code with this unorthodox version, I can't wait for Track 2 libraries for these as much as you do.

I've done this a few times now, including the QnA Maker last time that probably looked really offensive from your perspective of upholding engineering excellence. But I would really appreciate it if you can feel my pain here and make it a little easier for me to do this ugly work no one else wants to do. Thanks!

@anuchandy
Copy link
Member

I agree with Jianghao; If we can continue the versioning scheme already established, it will be less confusing for existing customers of track1 cognitive libs. Ref computer-version track1 versions here. As we move these libs to track2, we can follow the new versioning scheme.

@JimSuplizio
Copy link
Contributor

At this point if @JonathanGiles is OK then go for it.

@jianghaolu
Copy link
Contributor Author

Thanks guys for keeping an extra set of eyes on this! I hope we will soon switch to Track 2 generator and deprecate all these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants