Conversation
joshfree
added
Client
| <dependency> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpclient</artifactId> | ||
| <version>4.5.8</version> |
There was a problem hiding this comment.
Hey, our versioning story is managed by a series of scripts to keep dependency versions aligned. Can you add this annotation and follow the instructions to update to the proper version?
https://github.com/Azure/azure-sdk-for-java/blob/master/CONTRIBUTING.md#versions-and-versioning
<!-- {x-version-update;org.apache.httpcomponents:httpclient;external_dependency} -->
| import com.microsoft.azure.servicebus.primitives.ServiceBusException; | ||
| import com.microsoft.azure.servicebus.primitives.TimeoutException; | ||
| import com.microsoft.azure.servicebus.primitives.Util; | ||
| import com.microsoft.azure.servicebus.*; |
There was a problem hiding this comment.
Star imports are not allowed. You may have to update IntelliJ to not change it to a star import.
| private ManagementClientAsync asyncClient; | ||
|
|
||
| public ManagementClient(ConnectionStringBuilder connectionStringBuilder) { | ||
| public ManagementClient(ConnectionStringBuilder connectionStringBuilder) throws InterruptedException, ServiceBusException { |
There was a problem hiding this comment.
Since this is an existing public-facing API, this will break existing customers. You could catch the checked exceptions and throw an unchecked one to main compat.
| import java.net.URI; | ||
| import java.net.URISyntaxException; | ||
| import java.net.URL; | ||
| import java.net.*; |
| * @param clientSettings - client settings. | ||
| */ | ||
| public ManagementClientAsync(URI namespaceEndpointURI, ClientSettings clientSettings) { | ||
| // public ManagementClientAsync(URI namespaceEndpointURI, ClientSettings clientSettings) { |
| @@ -0,0 +1,276 @@ | |||
| package com.microsoft.azure.servicebus; | |||
| public List<Proxy> select(URI uri) { | ||
| if (uri != null | ||
| && uri.getHost() != null | ||
| // && uri.getHost().equalsIgnoreCase(proxyHostName) |
|
|
||
| import static java.nio.charset.StandardCharsets.UTF_8; | ||
|
|
||
| public class DaxiTest { |
| import static java.nio.charset.StandardCharsets.UTF_8; | ||
|
|
||
| public class DaxiTest { | ||
| static final Gson GSON = new Gson(); |
| ExecutorService executor = Executors.newCachedThreadPool(); | ||
| try { | ||
| executor.invokeAny(Arrays.asList(() -> { | ||
| System.in.read(); |
There was a problem hiding this comment.
System.in.read()? Will this block forever? Or do you expect users to interact with this test.
|
This is only my draft branch that I experimented something. The one that I completed is already merged: #11108 |
4 participants
No description provided.