cosmosdb analyticalStorage -> analyticalStore#10728
Merged
moderakh merged 2 commits intoAzure:masterfrom May 7, 2020
Merged
Conversation
moderakh
added
the
cosmos:v4-item
moderakh
requested review from
David-Noble-at-work,
kirankumarkolli,
kushagraThapar and
mbhaskar
as code owners
kushagraThapar
requested changes
May 5, 2020
Member
kushagraThapar
left a comment
kushagraThapar
left a comment
There was a problem hiding this comment.
Should we also change the documentation here ?
/**
* Sets the analytical storage time to live in seconds for items in a container from the Azure Cosmos DB service.
*
* It is an optional property. A valid value must be either a nonzero positive integer, '-1', or 0.
* By default, AnalyticalStorageTimeToLive is set to 0 meaning the analytical store is turned off for the container;
* -1 means documents in analytical store never expire. --> storage ?
* The unit of measurement is seconds. The maximum allowed value is 2147483647.
Please check if there is any other place that we need to change. Otherwise looks good.
Contributor
Author
|
|
Contributor
Author
|
@kushagraThapar done |
kushagraThapar
approved these changes
May 5, 2020
Member
kushagraThapar
left a comment
kushagraThapar
left a comment
There was a problem hiding this comment.
LGTM, thanks @moderakh
Contributor
Author
|
/azp run java - cosmos - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
analyticalStorage -> analyticalStore