Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ServiceResponse<> wrappers in most methods #1060

Merged
merged 5 commits into from
Sep 7, 2016
Merged

Remove ServiceResponse<> wrappers in most methods #1060

merged 5 commits into from
Sep 7, 2016

Conversation

jianghaolu
Copy link
Contributor

See Azure/autorest#1405

Used to be

ServiceResponse<Foo> getFoo();
Future<ServiceResponse<Foo>> getFooAsync(Callback<ServiceResponse<Foo>> cb);
Observable<ServiceResponse<Foo>> getFooAsync();

Now it's

Foo getFoo();
Future<Foo> getFooAsync(Callback<Foo> cb);
Observable<Foo> getFooAsync();
Observable<ServiceResponse<Foo>> getFooWithServiceResponse();

@jianghaolu
Regenerate with 20160906 autorest
3552614
@jianghaolu
Squashed 'runtimes/' changes from 930fbf5..3010c5c
14c7898 
3010c5c Merge pull request Azure#52 from jianghaolu/unwrap
c78b9c5 Merge commit '9934126e3d2115bedd890f8226cdf1c2c6d39a48' into unwrap
ac146e8 Fix errors
670b55e Merge pull request Azure#51 from jianghaolu/09062016
b5aa0f4 Remove ServiceResponse<> wrappers in most methods
a55439f fixed page listing for no item lists.
e132607 Remove redundant sync & callback based applys
d0191c7 Merge commit '794b2abafedf65c2052f2a7a5932155662de8ab1' into rx
7fb2d38 Fix socket timeout and parallel creation
2c7a100 Fix checkstyle errors
866a220 Adapt fluent impls to use native observables
e9fa2de Fix pagings with headers
ffc5544 Merge commit 'dc9cf4f0b75ac3672a3e125fa2b905dcab7d46f1' into rx
a1c0ae4 Generated code returns observables
7814d4f Merge commit '65d59d6f659b227b9936911c99f9cd053249af86' into rx
de94443 Merge pull request Azure#49 from Azure/sdk_1026
218ef3a Merge pull request Azure#47 from Azure/sdk_1023
13f7e4b Merge pull request Azure#46 from Azure/sdk_1021
6b54fd6 Merge pull request Azure#44 from Azure/sdk_1015
2572366 Merge branch 'master' of github.com:Azure/azure-sdk-for-java into rx
b8004bc Merge pull request Azure#1023 from anuchandy/fixrawtype
ac5100f Fixing the javadoc error and formatting errors for key vault
9980d1f Fixing a bunch of RawType usages and minor improvments in simplying callback
7c46138 Merge pull request Azure#45 from jianghaolu/autorest_1343

git-subtree-dir: runtimes
git-subtree-split: 3010c5c
@jianghaolu
Merge commit '14c789805ffe68c1ced5dbe0f71448095216fcc1' into unwrap
0679dd7
@jianghaolu
Fix errors from merge
d31dcf4
@jianghaolu
Address checkstyle
ad3a89b
@azuresdkci
Copy link
Contributor

Runtime changes detected. pull request created. CI running: Build Status

@azuresdkci azuresdkci mentioned this pull request Sep 7, 2016
Merged
@martinsawicki
Copy link

neat!

@martinsawicki martinsawicki merged commit b14fc66 into Azure:master Sep 7, 2016
jianghaolu added a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Sep 26, 2016
@jianghaolu
Squashed 'runtimes/' changes from 3010c5c..64c3003
122f582 
64c3003 Merge pull request Azure#54 from Azure/sdk_1045
a29b72b Merge pull request Azure#53 from Azure/sdk_1060
524db4a Merge pull request Azure#42 from Azure/sdk_1008
ffab45d Merge pull request Azure#1060 from jianghaolu/unwrap
626b093 Merge ad3a89b into cc5fdb3
9be12ef Fix errors from merge
9732907 Merge commit '14c789805ffe68c1ced5dbe0f71448095216fcc1' into unwrap
0a85d84 applyAsync on a root resource should create a dependency resource only if it is not already created and root resource always needs to be updated in this case
65a9fd6 Merge f8a29d6 into ae00855
3c266c4 Add graph tests

git-subtree-dir: runtimes
git-subtree-split: 64c3003
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
Merge pull request Azure#1060 from jianghaolu/unwrap
4a334dd 
Remove ServiceResponse<> wrappers in most methods
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this pull request Feb 27, 2017
Merge pull request Azure#1060 from jianghaolu/unwrap
e078df5 
Remove ServiceResponse<> wrappers in most methods
sima-zhu pushed a commit to sima-zhu/azure-sdk-for-java that referenced this pull request Mar 21, 2019
Merge pull request Azure#1060 from jianghaolu/unwrap
ffab45d 
Remove ServiceResponse<> wrappers in most methods
sima-zhu pushed a commit to sima-zhu/azure-sdk-for-java that referenced this pull request Mar 21, 2019
@jianghaolu
Merge pull request Azure#53 from Azure/sdk_1060
a29b72b 
[Automatic PR] SDK changes from pull request Azure#1060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jianghaolu @azuresdkci @martinsawicki @azurecla