Supply ServiceDirectory to uses of remove-test-resources.yml #10591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run java - smoke-tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - appconfiguration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
danieljurek
requested review from
JimSuplizio,
mitchdenny and
weshaggard
as code owners
JimSuplizio
approved these changes
Apr 29, 2020
Contributor
JimSuplizio
left a comment
JimSuplizio
left a comment
There was a problem hiding this comment.
The changes look fine. In the future if you're creating a PR in a language branch that is dependent on a PR on the tools branch can you please add that PR link to the description?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change that this is merging ahead of is: Azure/azure-sdk-tools#549
If we don't add the
ServiceDirectorywe'll see failures during the de-provisioning step.