Spring Boot migration - AAD starter#10285
Merged
hemanttanwar merged 14 commits intoAzure:masterfrom Apr 29, 2020
Merged
Conversation
saragluna
requested review from
JimSuplizio,
JonathanGiles,
anuchandy,
danieljurek,
hemanttanwar,
joshfree,
mitchdenny,
srnagar and
weshaggard
as code owners
srnagar
reviewed
Apr 23, 2020
srnagar
reviewed
Apr 23, 2020
...va/com/microsoft/azure/spring/autoconfigure/aad/AADAppRoleStatelessAuthenticationFilter.java
Show resolved
Hide resolved
...va/com/microsoft/azure/spring/autoconfigure/aad/AADAppRoleStatelessAuthenticationFilter.java
Show resolved
Hide resolved
sdk/spring/azure-spring-boot/src/main/java/com/microsoft/azure/spring/support/GetHashMac.java
Show resolved
Hide resolved
sdk/spring/azure-spring-boot/src/test/resources/test-private-key.txt
Outdated
Show resolved
Hide resolved
...va/com/microsoft/azure/spring/autoconfigure/aad/AADAppRoleStatelessAuthenticationFilter.java
Show resolved
Hide resolved
...va/com/microsoft/azure/spring/autoconfigure/aad/AADAppRoleStatelessAuthenticationFilter.java
Show resolved
Hide resolved
hemanttanwar
suggested changes
Apr 26, 2020
Contributor
hemanttanwar
left a comment
hemanttanwar
left a comment
There was a problem hiding this comment.
- Is this normal not to have java doc on public API ? Since user will look public API, we should add java doc on them.
- I also do not see sample code snippet as java doc in Public classes. For examlpe https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusSenderClient.java#L18
I would assume that developer will get benefit of this java doc code snippet.
Member
Author
Java doc added for public APIs. As for the second question, we'll have a bunch of sample projects to help users. These Spring Boot projects are mainly for helping users to auto-configure our SDK clients and the way they use it would be like providing properties in Spring property files. |
hemanttanwar
approved these changes
Apr 27, 2020
srnagar
approved these changes
Apr 28, 2020
| ### Snapshots | ||
| [](https://oss.sonatype.org/content/repositories/snapshots/com/microsoft/azure/azure-spring-boot/) | ||
|
|
||
| Snapshots built from `master` branch are available, add [maven repositories](https://maven.apache.org/settings.html#Repositories) configuration to your pom file as below. |
Member
There was a problem hiding this comment.
Any reason for recommending using SNAPSHOT versions instead of release versions?
Member
Author
There was a problem hiding this comment.
Snapshots are the daily built versions, it could let users try our new features without waiting for a release.
sdk/spring/azure-spring-boot/src/main/java/com/microsoft/azure/spring/support/GetHashMac.java
Outdated
Show resolved
Hide resolved
sdk/spring/azure-spring-boot/src/main/java/com/microsoft/azure/telemetry/TelemetrySender.java
Show resolved
Hide resolved
...boot/src/test/java/com/microsoft/azure/spring/autoconfigure/aad/MicrosoftGraphConstants.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split PR #9395 into several PRs for the convenience of reviewing.
Modules included:
azure-spring-boot
azure-spring-boot-starter
azure-spring-boot-starter-active-directory