Correct Azure Key Vault Certificates .md files content inconsistency and unclear#10118
Merged
vcolin7 merged 27 commits intoAzure:masterfrom May 6, 2020
Merged
Conversation
jongio
requested changes
Apr 13, 2020
samvaity
reviewed
Apr 22, 2020
| @@ -69,7 +69,7 @@ Here is [Azure Cloud Shell](https://shell.azure.com/bash) snippet below to | |||
| * Grant the above mentioned application authorization to perform key operations on the keyvault: | |||
Member
There was a problem hiding this comment.
to perform certificate operations?
| Create a Certificate to be stored in the Azure Key Vault. | ||
| - `beginCreateCertificate` creates a new certificate in the key vault. if the certificate with name already exists then a new version of the certificate is created. | ||
| Create a certificate to be stored in the Azure Key Vault. | ||
| - `beginCreateCertificate` creates a new certificate in the Azure Key Vault. if the certificate with name already exists then a new version of the certificate is created. |
Member
There was a problem hiding this comment.
Should all certificate be updated to Certificate?
Member
There was a problem hiding this comment.
I think it should be the other way around.
| // The List Certificates operation returns certificates without their full properties, so for each certificate returned we call `getCertificate` to get all its attributes excluding the policy. | ||
| certificateAsyncClient.listPropertiesOfCertificates() | ||
| .subscribe(certificateProperties -> certificateAsyncClient.getCertificate(certificateProperties.getName(), | ||
| .subscribe(certificateProperties -> certificateAsyncClient.getCertificateVersion(certificateProperties.getName(), |
jongio
approved these changes
Apr 23, 2020
vcolin7
requested changes
Apr 24, 2020
Member
vcolin7
left a comment
vcolin7
left a comment
There was a problem hiding this comment.
I added a number of change requests. Also, there are many other small improvements and corrections I think we can make to this file but couldn't add them to this review, is it possible I can contribute to your branch so I can add them @FredGao-new?
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
Co-Authored-By: vcolin7 <vicolina@microsoft.com>
…xt and code samples.
vcolin7
approved these changes
Apr 27, 2020
Member
|
/check-enforcer reset |
Member
|
/check-enforcer evaluate |
2 similar comments
Contributor
|
/check-enforcer evaluate |
Member
|
/check-enforcer evaluate |
Member
|
/azp run java - keyvault - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
g2vinay
reviewed
May 1, 2020
| System.out.println("Delete Status: " + pollResponse.getStatus().toString()); | ||
| System.out.println("Delete Certificate Name: " + pollResponse.getValue().getName()); | ||
| System.out.println("Certificate Delete Date: " + pollResponse.getValue().getDeletedOn().toString()); | ||
| System.out.printf("Deletetion status: %s\n", pollResponse.getStatus().toString()); |
g2vinay
approved these changes
May 1, 2020
vcolin7
reviewed
May 1, 2020
Member
|
/check-enforcer reset |
Member
|
/check-enforcer evaluate |
Member
|
/check-enforcer reset |
Member
|
/check-enforcer evaluate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create PR to address this issue.