Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: batch method does not validate Operations types #126

Closed
joostdenijs opened this issue Jul 16, 2012 · 2 comments
Closed

Table: batch method does not validate Operations types #126

joostdenijs opened this issue Jul 16, 2012 · 2 comments
Milestone

Comments

@joostdenijs
Copy link
Contributor

Moved from private repository

The Operation type can be implemented by the user, then plugged into the BatchOperations.getOperations list and passed to the batch method. However, the code (increateBatchRequestBody and parseBatchResponse) only acts on the operations when they are instances of the prefefined *Operation types, other types just fall out the end of the if..else if... chain.

It would be good to close those if...else if... chains with a trailing else { throw "Unexpected input blah" }. This would also help out of the user inserts a null value in the list.

joostdenijs pushed a commit to joostdenijs/azure-sdk-for-java that referenced this issue Jan 18, 2013
Change the pom xml id references from azure->windowsazure fixes Azure#126
@jcookems
Copy link
Contributor

Closed by accident (commit referenced this id, but was for a different repo)

@jcookems jcookems reopened this Jan 19, 2013
@gcheng
Copy link

gcheng commented Feb 12, 2013

low priority, close, will open if customer ask.

@gcheng gcheng closed this as completed Feb 12, 2013
gcheng pushed a commit to gcheng/azure-sdk-for-java that referenced this issue Sep 6, 2013
jianghaolu pushed a commit to jianghaolu/azure-sdk-for-java that referenced this issue Apr 5, 2017
navalev pushed a commit to navalev/azure-sdk-for-java that referenced this issue Dec 24, 2019
…zure#126)

* merging DnsSuffix and servicename

* incorporate CR comments

* fix merge issues

* fix UTs

* cr comments

* cr comments

* fix failing UTs after merge issues

* fix merge issues
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants