Merged
Conversation
e.Table.tsc.client.exec can return nil resp and non-nil err. This causes resp.StatusCode to crash with nil dereference. This change adds the nil check on resp before accessing StatusCode.
jhendrixMSFT
approved these changes
Feb 26, 2020
|
Can one of the admins verify this patch? |
Member
|
@ArcturusZhang can you please release an updated SDK with this fix? |
Member
Author
|
Thanks @jhendrixMSFT! @ArcturusZhang our Container Networking release for GA depends on this. Appreciate you releasing the updated SDK tonight. |
ArcturusZhang
pushed a commit
to ArcturusZhang/azure-sdk-for-go
that referenced
this pull request
Feb 27, 2020
e.Table.tsc.client.exec can return nil resp and non-nil err. This causes resp.StatusCode to crash with nil dereference. This change adds the nil check on resp before accessing StatusCode.
jhendrixMSFT
pushed a commit
that referenced
this pull request
Feb 27, 2020
* Fix SDK Automation Failure (#7545) * Fix nil dereference error (#7546) e.Table.tsc.client.exec can return nil resp and non-nil err. This causes resp.StatusCode to crash with nil dereference. This change adds the nil check on resp before accessing StatusCode. * Generated from latest swagger * v40.0.0 Co-authored-by: Phoenix He <tih@microsoft.com> Co-authored-by: Ashvin Deodhar <asdeodha@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e.Table.tsc.client.exec can return nil resp and non-nil err. This causes
resp.StatusCode to crash with nil dereference. This change adds the
nil check on resp before accessing StatusCode.