V10#599
Conversation
There was a problem hiding this comment.
Is this funky casing due to swagger authoring or a bug in the generator?
There was a problem hiding this comment.
It is because of the PR I submitted to Autorest
There was a problem hiding this comment.
(This last commit was not generated from master, but from my local branch)
There was a problem hiding this comment.
I see, but shouldn't this be APIID?
| @@ -504,9 +534,9 @@ func generate(service *service) { | |||
| fmt.Printf("Generating %s...\n\n", service.Fullname) | |||
| delete(service) | |||
|
|
|||
| // | ||
| // resourceGroupName is the name of the resource group. serviceName is the name | ||
| // of the API Management service. apiID is aPI identifier. Must be unique in | ||
| // of the API Management service. aPIID is aPI identifier. Must be unique in |
There was a problem hiding this comment.
Hmmm, is there anything we can do about this? It definitely seems regressive.
There was a problem hiding this comment.
Do you prefer APIID ?
There was a problem hiding this comment.
Well, I actually prefer apiID but I'm not sure if there's anyway to get that back without causing further breaking changes.
There was a problem hiding this comment.
The reason this appeared is because of this... Azure/autorest#2220 (just for reference)
In this PR, travis failed in the first commit with this message...
arm/hdinsight/models.go:534:2: struct field ClusterUsersGroupDNs should be ClusterUsersGroupDNS
| // endswith | top is number of records to return. skip is number of records to | ||
| // skip. | ||
| func (client APIProductsClient) ListByAPI(resourceGroupName string, serviceName string, apiID string, filter string, top *int32, skip *int32) (result ProductCollection, err error) { | ||
| func (client APIProductsClient) ListByApis(resourceGroupName string, serviceName string, aPIID string, filter string, top *int32, skip *int32) (result ProductCollection, err error) { |
There was a problem hiding this comment.
Make sure to callout this breaking change
| // Contract parameters. ifMatch is eTag of the API entity. ETag should match | ||
| // the current entity state in the header response of the GET request or it | ||
| // should be * for unconditional update. | ||
| func (client ApisClient) Update(resourceGroupName string, serviceName string, aPIID string, parameters APIUpdateContract, ifMatch string) (result autorest.Response, err error) { |
There was a problem hiding this comment.
PatchParameters -> APIUpdateContract would be another good thing to call out.
| | arm/commerce | 2015-06-01-preview | refactor | | ||
| | arm/compute | 2016-04-30-preview | refactor | | ||
| | arm/consumption | 2017-04-24-preview | new | | ||
| | arm/containerregistry | 2017-06-01-preview | update to latest swagger & refactor | |
There was a problem hiding this comment.
This api-version is still under private preview and the SDK is not supposed to be published yet. Can we keep the 2017-03-01 version? /cc @sajayantony
There was a problem hiding this comment.
Will regen for 2017-03-01 then :)
There was a problem hiding this comment.
Thank you. What is the release pattern/process from dev to master? We have recently noticed a large number of calls from Go SDK to 2016-06-27-preview since it is the version in master branch.
There was a problem hiding this comment.
Each time we release we merge dev to master. We release every month.
There was a problem hiding this comment.
Done. Thanks for noticing this.
5 participants
PTAL
@marstr @jhendrixMSFT