Fix table query continuation token #5413
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
jhendrixMSFT
reviewed
Aug 2, 2019
| } | ||
|
|
||
| if ct.NextPartitionKey != "" && ct.NextRowKey != "" { | ||
| if ct.NextPartitionKey != "" || ct.NextRowKey != "" { |
Member
There was a problem hiding this comment.
Can it ever be the case that NextRowKey is not empty but NextParitionKey is?
Member
Author
There was a problem hiding this comment.
Storage docs didn't specifically mention if NextParitionKey could be empty, but it's a valid query to storage to have just NextRowKey.
Also from how other SDKs handle it, these three pagination headers NextTableName, NextPartitionKey, and NextRowKey don't have dependencies on each other. The non-empty ones will be added to the URL of the next request.
Member
|
Can you please retarget this PR against the |
Member
Author
|
Retarget to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5425
Azure Storage table query may return results with non-empty
x-ms-continuation-NextPartitionKeybut emptyx-ms-continuation-NextRowKey, see https://docs.microsoft.com/en-us/rest/api/storageservices/query-timeout-and-paginationThe current Go SDK implementation couldn't follow the continuation token for these cases.
Reference to .NET implementation https://github.com/Azure/azure-storage-net/blob/fdc07726910ead3281b14b2769a92b2fea68bd97/Lib/Common/Table/TableContinuationToken.cs
latestbranch.