Skip to content

Generated the Application Insights SDK#473

Closed
tombuildsstuff wants to merge 5 commits intoAzure:masterfrom
tombuildsstuff:azurerm-application-insights
Closed

Generated the Application Insights SDK#473
tombuildsstuff wants to merge 5 commits intoAzure:masterfrom
tombuildsstuff:azurerm-application-insights

Conversation

@tombuildsstuff
Copy link
Copy Markdown
Contributor

Should probably wait for Azure/azure-rest-api-specs#757 to be merged before merging this

  • Implemented CRUD support for the Application Insights endpoints in the SDK

@msftclas
Copy link
Copy Markdown

Hi @tombuildsstuff, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@jeffwilcox
Copy link
Copy Markdown

Hi, I'm going to have a machine account close and re-open this pull request. This sometimes is sufficient to bump the CLA subsystem to evaluate the CLA. Sorry for any inconvenience!

@msftgits msftgits closed this Nov 29, 2016
@msftgits msftgits reopened this Nov 29, 2016
@msftclas
Copy link
Copy Markdown

Hi @tombuildsstuff, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@tombuildsstuff
Copy link
Copy Markdown
Contributor Author

Any chance someone could take a look at this PR please? :)

@marstr
Copy link
Copy Markdown
Member

marstr commented Dec 13, 2016

Howdy Tom! Sorry for the lack of activity here. Per your comment at the top, we were waiting to look at this until this pull request was accepted in case another iteration of generation is required. Seem reasonable? We will continue to triage this pull request along with all other open pull-requests, it will not go forgotten.

@tombuildsstuff
Copy link
Copy Markdown
Contributor Author

@marstr thanks for taking a look :)

That's fair enough, I guess I was hoping for some guidance given the Rest API Specs team haven't had a chance to look at this either.

I was half hoping that this would make it into v7 / v8 of the SDK tbh but alas. For now I'm going to implement support for Application Insights into Riviera - because I don't think this'll be available in an SDK before (presumably v9?) in late January?

@salameer
Copy link
Copy Markdown
Member

Hi @tombuildsstuff well the good news is that we have contacted the AI team for the other PR and they're intending to review it, which will unblock this issue eventually. the little bit of unfortuante new is I dont have enough clarity on the timelines yet :( .. what we can promise for now is that we'll keep following up (Nagging :)) on the other PR to happen and keep you posted of updates here

@tombuildsstuff
Copy link
Copy Markdown
Contributor Author

@salameer thanks a bunch :)

@marstr
Copy link
Copy Markdown
Member

marstr commented Apr 20, 2017

Alright, @tombuildsstuff! The time has come to finally resolve this. It seems that the swaggers for the insights service are done, and that we can generate them in v10.

@tombuildsstuff
Copy link
Copy Markdown
Contributor Author

@marstr Awesome - I'll close this PR for the moment then :)

One minor thing, I think you meant to link to the arm-appinsights package rather than the arm-insights one, which from what I can tell is what's now called Azure Monitoring?

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants