Sync eng/common directory with azure-sdk-tools for PR 14343#26114
Merged
chidozieononiwu merged 1 commit intomainfrom Mar 4, 2026
Merged
Sync eng/common directory with azure-sdk-tools for PR 14343#26114chidozieononiwu merged 1 commit intomainfrom
chidozieononiwu merged 1 commit intomainfrom
Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
Syncs eng/common pipeline templates with updates from azure-sdk-tools PR 14343, specifically adjusting the npm publish job behavior when targeting the public npmjs registry.
Changes:
- Adds a pre-publish step (npmjs-only) to delete a repository
.npmrcso publishing uses the default npmjs registry.
Comment on lines
+78
to
+85
| $npmrcPath = "$(System.DefaultWorkingDirectory)/.npmrc" | ||
| if (Test-Path $npmrcPath) { | ||
| Remove-Item -Path $npmrcPath -Force | ||
| Write-Host "Deleted $npmrcPath to use default npmjs registry." | ||
| } else { | ||
| Write-Host "No repo .npmrc found at $npmrcPath." | ||
| } | ||
| pwsh: true |
There was a problem hiding this comment.
Remove-Item failures can be non-terminating in PowerShell, so this step may still succeed even if .npmrc couldn't be removed (e.g., permission/locked file), potentially leaving npm configured to publish/query against the wrong registry. Consider making deletion a hard failure when the file exists (e.g., -ErrorAction Stop / $ErrorActionPreference='Stop' with a clear error message).
azure-sdk
force-pushed
the
sync-eng/common-AllowNpmJSAccess-14343
branch
from
b556b4f to
d9f5c93
Compare
chidozieononiwu
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14343 See eng/common workflow