Sync eng/common directory with azure-sdk-tools for PR 14196#26071
Merged
Sync eng/common directory with azure-sdk-tools for PR 14196#26071
Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory with changes from azure-sdk-tools PR 14196. The changes primarily add functionality to remove Azure Storage Sync Services that can block resource group deletion, update default subscription handling to use the "Azure SDK Test Resources - TME" subscription, and add missing module requirements.
Changes:
- Added
Remove-StorageSyncServiceshelper function to clean up Storage Sync Services and their nested resources (endpoints and sync groups) before resource group deletion - Updated default test subscription from "Azure SDK Developer Playground" to "Azure SDK Test Resources - TME" across test resource management scripts
- Added Az.Storage and Az.StorageSync module requirements to Remove-TestResources.ps1 to support storage-related cleanup operations
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/scripts/Helpers/Resource-Helpers.ps1 | Added new Remove-StorageSyncServices function to handle cleanup of Storage Sync Services with nested resources |
| eng/common/TestResources/Update-TestResources.ps1 | Updated default subscription to TME, added WarningAction suppression, and fixed subscription references |
| eng/common/TestResources/Remove-TestResources.ps1 | Added module requirements, updated default subscription to TME, added WarningAction suppression, and integrated Storage Sync cleanup |
benbp
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14196 See eng/common workflow