Sync eng/common directory with azure-sdk-tools for PR 13968#26024
Sync eng/common directory with azure-sdk-tools for PR 13968#26024chidozieononiwu merged 2 commits intomainfrom
Conversation
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull request overview
This PR syncs the eng/common directory with azure-sdk-tools PR #13968, updating the test resource deployment pipeline template to support separate ArmTemplateParameters and AdditionalParameters configuration.
Changes:
- Added new
AdditionalParametersparameter to the pipeline template with default value'@{}' - Renamed the PowerShell script parameter from
-AdditionalParametersto-ArmTemplateParametersfor passing ARM template parameters - Added new
-AdditionalParametersparameter for passing additional pipeline parameters
| @subscriptionConfiguration ` | ||
| -AdditionalParameters ${{ parameters.ArmTemplateParameters }} ` | ||
| -ArmTemplateParameters ${{ parameters.ArmTemplateParameters }} ` | ||
| -AdditionalParameters {{ parameters.AdditionalParameters }} ` |
There was a problem hiding this comment.
Missing $ prefix before the template expression. This should be ${{ parameters.AdditionalParameters }} instead of {{ parameters.AdditionalParameters }}. Without the $ prefix, the Azure Pipelines template expression will not be evaluated correctly, and the parameter value will not be passed to the PowerShell script.
| -AdditionalParameters {{ parameters.AdditionalParameters }} ` | |
| -AdditionalParameters ${{ parameters.AdditionalParameters }} ` |
| @subscriptionConfiguration ` | ||
| -AdditionalParameters ${{ parameters.ArmTemplateParameters }} ` | ||
| -ArmTemplateParameters ${{ parameters.ArmTemplateParameters }} ` | ||
| -AdditionalParameters {{ parameters.AdditionalParameters }} ` |
There was a problem hiding this comment.
Missing $ prefix before the template expression. This should be ${{ parameters.AdditionalParameters }} instead of {{ parameters.AdditionalParameters }}. Without the $ prefix, the Azure Pipelines template expression will not be evaluated correctly, and the parameter value will not be passed to the PowerShell script.
| -AdditionalParameters {{ parameters.AdditionalParameters }} ` | |
| -AdditionalParameters ${{ parameters.AdditionalParameters }} ` |
azure-sdk
force-pushed
the
sync-eng/common-EnableLiveTestOverHttp-13968
branch
from
60c232f to
d16a3f2
Compare
chidozieononiwu
deleted the
sync-eng/common-EnableLiveTestOverHttp-13968
branch
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13968 See eng/common workflow