Skip unsafeptr check for storage SDKs#25856
Merged
jhendrixMSFT merged 2 commits intoAzure:mainfrom Jan 12, 2026
Merged
Conversation
It reports false positives on Windows. Fix malformed module version string.
jhendrixMSFT
requested review from
benbp,
bhansalivikas,
gapra-msft,
souravgupta-msft,
tanyasethi-msft and
weshaggard
as code owners
benbp
approved these changes
Jan 9, 2026
This was referenced Jan 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses two issues: (1) disables the unsafeptr check in go vet for storage SDKs to avoid false positives on Windows related to memory-mapped file handling, and (2) corrects the module version string format by adding the "v" prefix to align with Go module versioning conventions.
- Adds build script logic to conditionally disable
unsafeptrcheck for storage SDKs on Windows - Updates comment documentation in
mmf_windows.goto reference the relevant GitHub issue - Fixes malformed module version string in azblob from "1.6.3-beta.1" to "v1.6.3-beta.1"
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk/storage/azblob/internal/shared/mmf_windows.go | Replaces nolint directive with explanatory comment referencing GitHub issue #58625 |
| sdk/storage/azblob/internal/exported/version.go | Adds "v" prefix to module version string to match Go semantic versioning convention |
| eng/scripts/build.ps1 | Adds conditional logic to disable unsafeptr check for storage SDKs on Windows |
tanyasethi-msft
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It reports false positives on Windows.
Fix malformed module version string.