Skip to content

Sync eng/common directory with azure-sdk-tools for PR 13222#25745

Merged
azure-sdk merged 1 commit intomainfrom
sync-eng/common-users/pahallis/local-group-start-13222
Dec 9, 2025
Merged

Sync eng/common directory with azure-sdk-tools for PR 13222#25745
azure-sdk merged 1 commit intomainfrom
sync-eng/common-users/pahallis/local-group-start-13222

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#13222 See eng/common workflow

Copilot AI review requested due to automatic review settings December 9, 2025 07:13
@azure-sdk azure-sdk requested a review from a team as a code owner December 9, 2025 07:13
@azure-sdk azure-sdk requested a review from hallipr December 9, 2025 07:13
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Dec 9, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs the eng/common directory with the azure-sdk-tools repository, specifically incorporating changes from PR #13222. The change enhances the LogGroupStart function to handle scenarios where neither Azure DevOps nor GitHub Actions logging is available.

Key Changes

  • Added an else clause to the LogGroupStart function to provide a fallback output format ("> $args") when neither DevOps nor GitHub logging is supported
Comments suppressed due to low confidence (1)

eng/common/scripts/logging.ps1:109

  • The LogGroupEnd function is missing a corresponding else clause to handle cases where neither DevOps nor GitHub logging is supported. This creates an inconsistency with LogGroupStart, which now includes an else clause. Consider adding an else clause to LogGroupEnd for consistency and completeness.
function LogGroupEnd() {
  if (Test-SupportsDevOpsLogging) {
    Write-Host "##[endgroup]"
  }
  elseif (Test-SupportsGitHubLogging) {
    Write-Host "::endgroup::"
  }
}

@azure-sdk azure-sdk merged commit a006df1 into main Dec 9, 2025
22 checks passed
@azure-sdk azure-sdk deleted the sync-eng/common-users/pahallis/local-group-start-13222 branch December 9, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants