[azsystemevents] Remove gopls#25555
Merged
richardpark-msft merged 8 commits intoAzure:mainfrom Nov 5, 2025
Merged
Conversation
3 tasks
Chopping out a check that never worked anyways and isn't really needed.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR contains code generation updates and refactoring of the internal generate tool for the azsystemevents package. The changes improve code generation by simplifying the implementation to use string-based operations instead of relying on the external gopls tool.
Key changes:
- Removed dependency on the
goplstool for code manipulation, replacing it with regex-based string operations - Simplified the code generation flow to work entirely with in-memory strings
- Updated dependency versions (azcore v1.18.1 → v1.19.0, azinternal v1.11.1 → v1.11.2)
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/messaging/eventgrid/azsystemevents/version.go | Added new version file with module metadata |
| sdk/messaging/eventgrid/azsystemevents/time_rfc3339.go | Reordered imports to follow standard library first convention |
| sdk/messaging/eventgrid/azsystemevents/time_rfc1123.go | Removed unused RFC1123 time handling code |
| sdk/messaging/eventgrid/azsystemevents/testdata/_metadata.json | Updated emitter version to 0.8.3 |
| sdk/messaging/eventgrid/azsystemevents/models_serde.go | Fixed comments for internal types and reordered imports |
| sdk/messaging/eventgrid/azsystemevents/internal/gopls/gopls.go | Removed entire gopls package as it's no longer needed |
| sdk/messaging/eventgrid/azsystemevents/internal/generate/regex_helpers.go | Refactored to use string-based operations instead of file I/O |
| sdk/messaging/eventgrid/azsystemevents/internal/generate/generate_test.go | Refactored tests to work with strings instead of temporary files |
| sdk/messaging/eventgrid/azsystemevents/internal/generate/generate_constants.go | Changed to accept string input instead of file reader |
| sdk/messaging/eventgrid/azsystemevents/internal/generate/generate.go | Major refactoring to work with in-memory strings and simplified logic |
| sdk/messaging/eventgrid/azsystemevents/go.sum | Updated dependency checksums |
| sdk/messaging/eventgrid/azsystemevents/go.mod | Updated dependency versions |
| sdk/messaging/eventgrid/azsystemevents/build.go | Added gofmt step before code generation |
sdk/messaging/eventgrid/azsystemevents/internal/generate/generate_constants.go
Show resolved
Hide resolved
sdk/messaging/eventgrid/azsystemevents/internal/generate/regex_helpers.go
Show resolved
Hide resolved
sdk/messaging/eventgrid/azsystemevents/internal/generate/generate.go
Outdated
Show resolved
Hide resolved
sdk/messaging/eventgrid/azsystemevents/internal/generate/generate.go
Outdated
Show resolved
Hide resolved
…ate.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
added 2 commits
November 5, 2025 23:06
jhendrixMSFT
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing references to any tools that aren't in the standard toolset, like gopls. Keeps our setup a bit simpler for the azure-rest-api-specs repo.
Part of the fix for #25554