[AutoPR sdk-resourcemanager/elasticsan/armelasticsan]-generated-from-SDK Generation - Go-5515644#25525
Open
azure-sdk wants to merge 2 commits intoAzure:mainfrom
Conversation
…ElasticSan/ElasticSan/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'c86c7e36fb15171a9967d9fdc47784f2e4202ca6' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5515644 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
github-actions
bot
added
the
Mgmt
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
yifanz7
requested review from
JiaqiZhang-Dev,
lirenhe and
tadelesh
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the Azure ElasticSan SDK from AutoRest-based generation to the new Go Code Generator, updating the API version from 2024-07-01-preview to 2025-09-01. The changes include:
- Migration from AutoRest to Go Code Generator for code generation
- API version update to
2025-09-01 - Removal of soft-delete related features (DeleteRetentionPolicy, XMSAccessSoftDeletedResources)
- Removal of ManagementClient and RestoreVolume functionality
- Updated example tests with proper response structure wrapping
- Dependency updates and improvements to pagination handling
- Updated copyright headers and code generation comments
Reviewed Changes
Copilot reviewed 44 out of 45 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| version.go | New file adding module version constants |
| tsp-location.yaml | New file specifying TypeSpec source location |
| testdata/_metadata.json | New metadata file for test data |
| volumesnapshots_client.go | Updated API version and removed FinalStateVia configuration |
| volumes_client.go | Updated API version, removed DeleteType parameter, removed XMSAccessSoftDeletedResources |
| volumegroups_client.go | Updated API version, removed XMSAccessSoftDeletedResources, fixed URL path casing |
| skus_client.go | Updated API version and improved pagination logic |
| operations_client.go | Updated API version and improved pagination logic |
| privateendpointconnections_client.go | Updated API version and improved pagination logic |
| privatelinkresources_client.go | Updated API version |
| models.go | Removed DeleteRetentionPolicy, updated documentation strings |
| models_serde.go | Removed DeleteRetentionPolicy serialization code |
| options.go | Removed DeleteType and XMSAccessSoftDeletedResources options |
| responses.go | Removed ManagementClientRestoreVolumeResponse |
| management_client.go | Entire file removed |
| *_example_test.go | Updated examples with new response wrapping and API version |
| fake/*.go | Updated fake server implementations |
| go.mod/go.sum | Updated dependencies |
tadelesh
approved these changes
Oct 31, 2025
tadelesh
approved these changes
Nov 4, 2025
Member
|
As the server rollout is running into some issues, we're not able to have the release now. |
tadelesh
requested changes
Nov 17, 2025
Member
tadelesh
left a comment
tadelesh
left a comment
There was a problem hiding this comment.
Hold merge before service's rollout.
Member
|
@tadelesh The server rollout is ready. Can we proceed with the release and target at the next release train by 2/27? Thanks! |
tadelesh
approved these changes
Jan 29, 2026
Member
|
@yifanz7 I approved the PR. You could continue the release according to the instruction in release plan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/elasticsan/resource-manager/Microsoft.ElasticSan/ElasticSan/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: 'c86c7e36fb15171a9967d9fdc47784f2e4202ca6' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5515644 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=e1ca6d7f-4cb5-f011-bbd2-6045bd07ef68 Submitted by: yifanzhang@microsoft.com
Release Plan Details
Spec pull request: Stable version 2025-09-01 with prevalidation and autoscale changes azure-rest-api-specs#37218
Spec API version: 2025-09-01