[[Containerregistry-typespec]]containerregistry/armcontainerregistry #25495
Closed
[[Containerregistry-typespec]]containerregistry/armcontainerregistry #25495
Conversation
…1.3.0-beta.4 generation from spec commit: 3855ffb4be0cd4d227b130b67d874fa816736c04
…2.0.0 generation from spec commit: 3855ffb4be0cd4d227b130b67d874fa816736c04
jliusan
requested review from
JiaqiZhang-Dev,
lirenhe and
tadelesh
as code owners
github-actions
bot
added
the
Mgmt
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure Container Registry Go SDK to use a new code generator (Microsoft Go Code Generator) and upgrades the API version from 2025-03-01-preview to 2025-11-01. The changes primarily involve:
- Switching from AutoRest to Go Code Generator for code generation
- Updating API version references throughout the codebase
- Refactoring client initialization with improved documentation
- Removing deprecated operations and test files
- Modifying HTTP request headers and polling behavior
Reviewed Changes
Copilot reviewed 74 out of 82 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tokens_client.go | Updated code generator attribution, API version (2025-11-01), removed FinalStateVia polling, added Content-Type headers |
| time_rfc3339.go | Updated code generator attribution only |
| testdata/_metadata.json | New file with API version metadata |
| tasks_client_example_test.go | Deleted entire example test file (1895 lines) |
| tasks_client.go | Deleted entire client implementation file (448 lines) |
| taskruns_client_example_test.go | Deleted entire example test file (404 lines) |
| taskruns_client.go | Deleted entire client implementation file (472 lines) |
| scopemaps_client_example_test.go | Updated examples with new generator, improved formatting, added import path v2 |
| scopemaps_client.go | Updated API version, removed FinalStateVia, added Content-Type headers, improved documentation |
| runs_client_example_test.go | Deleted entire example test file (275 lines) |
| runs_client.go | Deleted entire client implementation file (382 lines) |
| responses.go | Removed response types for deleted clients (Tasks, TaskRuns, Runs, AgentPools, etc.) |
| replications_client_example_test.go | Updated examples with new generator, improved formatting, added import path v2 |
| replications_client.go | Updated API version, removed FinalStateVia, added Content-Type headers |
| registries_client.go | Updated API version, removed FinalStateVia, removed GetBuildSourceUploadURL and ScheduleRun methods, changed ListUsages to pager, renamed PrivateLinkResource type |
| privateendpointconnections_client_example_test.go | Updated examples with new generator, improved formatting, added import path v2 |
| privateendpointconnections_client.go | Updated API version, removed FinalStateVia, added Content-Type headers |
| polymorphic_helpers.go | Deleted entire file with polymorphic unmarshalling helpers (85 lines) |
| operations_live_test.go | Updated import path to v2 |
| operations_client.go | Updated API version, improved documentation |
| containerregistry_live_test.go | Updated import path to v2 |
| func (client *RegistriesClient) getPrivateLinkResourceHandleResponse(resp *http.Response) (RegistriesClientGetPrivateLinkResourceResponse, error) { | ||
| result := RegistriesClientGetPrivateLinkResourceResponse{} | ||
| if err := runtime.UnmarshalAsJSON(resp, &result.PrivateLinkResource); err != nil { | ||
| if err := runtime.UnmarshalAsJSON(resp, &result.MyPrivateLinkResource); err != nil { |
There was a problem hiding this comment.
The field name 'MyPrivateLinkResource' uses unconventional prefix 'My'. Should be renamed to 'PrivateLinkResource' to follow Go naming conventions and match the documentation comment that refers to 'A private link resource'.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate base Azure/azure-rest-api-specs#37169 typespec