Sync eng/common directory with azure-sdk-tools for PR 12478#25439
Merged
Sync eng/common directory with azure-sdk-tools for PR 12478#25439
Conversation
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with azure-sdk-tools PR 12478, consolidating package validation logic and improving efficiency by reducing redundant authentication checks.
Key Changes:
- Consolidated
Validate-Package.ps1functionality intoValidate-All-Packages.ps1to reduce redundant authentication calls - Refactored
Update-DevOps-Release-WorkItem.ps1script into a reusable function withinDevOps-WorkItem-Helpers.ps1 - Added support for direct
PackageInfoFilesparameter alongside existingArtifactListapproach
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/common/scripts/Validate-All-Packages.ps1 | Major refactoring: consolidated package validation logic from Validate-Package.ps1, added new validation functions, and implemented dual-mode package processing (ArtifactList vs PackageInfoFiles) |
| eng/common/scripts/Prepare-Release.ps1 | Updated to call Update-DevOpsReleaseWorkItem as a function instead of script, improved error handling |
| eng/common/scripts/Helpers/DevOps-WorkItem-Helpers.ps1 | Added authentication check functions with global state management, converted Update-DevOps-Release-WorkItem.ps1 to Update-DevOpsReleaseWorkItem function |
| eng/common/pipelines/templates/steps/validate-all-packages.yml | Enhanced parameter definitions with explicit types and defaults, added PackageInfoFiles parameter support |
Comments suppressed due to low confidence (1)
eng/common/scripts/Validate-All-Packages.ps1:1
- The string "unknown" is used as a magic value in multiple places (lines 156, 157, 145). Consider defining this as a constant at the script level, such as
$UNKNOWN_VALUE = \"unknown\", to improve maintainability and make updates easier.
[CmdletBinding()]
fedcbde to
8d41d8b
Compare
raych1
approved these changes
Oct 17, 2025
azure-sdk
force-pushed
the
sync-eng/common-users/raych1/update-validat-pkg-template-12478
branch
from
8d41d8b to
f5df157
Compare
raych1
approved these changes
Oct 17, 2025
Member
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Member
|
/azp run go - pullrequest |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk
deleted the
sync-eng/common-users/raych1/update-validat-pkg-template-12478
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12478 See eng/common workflow