Skip to content

Conversation

@jliusan
Copy link
Member

@jliusan jliusan commented Sep 15, 2025

…2.0.0 generation from spec commit: 1004eed4202d64b48157c084fe2830760f8190f4
Copilot AI review requested due to automatic review settings September 15, 2025 06:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR is a major version release (v2.0.0) for the Azure Cognitive Services ARM SDK package that introduces breaking changes to the NetworkInjections types and updates various package references and versions throughout the codebase.

  • Updated module path to include /v2 suffix for major version upgrade
  • Changed NetworkInjections from a struct to a slice of NetworkInjection structs
  • Updated import paths, dependency versions, and spec references across all files

Reviewed Changes

Copilot reviewed 60 out of 61 changed files in this pull request and generated no comments.

Show a summary per file
File Description
version.go Added new version file with module info for v2.0.0
models.go Breaking change to NetworkInjections type structure
models_serde.go Updated serialization methods for renamed NetworkInjection type
go.mod Updated module path to v2 and dependency versions
constants.go Removed module constants (moved to version.go)
CHANGELOG.md Added v2.0.0 release notes documenting breaking changes
*_example_test.go Updated import paths to v2 across all example test files
fake/*_server.go Updated import paths and regex match validations
autorest.md Updated spec commit hashes and module version
README.md Updated installation instructions for v2

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Sep 15, 2025
@github-actions
Copy link

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/cognitiveservices/armcognitiveservices

@jliusan
Copy link
Member Author

jliusan commented Sep 18, 2025

The breaking changes are introduced and approved in this PR, @jhendrixMSFT , please approve this major version release by adding label of Approved Major Version, thanks.

@tadelesh
Copy link
Member

Since it is a service made breaking change, I added the label.

@jliusan jliusan merged commit 9f0afc6 into main Sep 29, 2025
19 checks passed
@jliusan jliusan deleted the release-cognitiveservices-armcognitiveservices-2.0.0-1757915993 branch September 29, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Major Version BreakingChange Mgmt This issue is related to a management-plane library. Stable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants