Sync eng/common directory with azure-sdk-tools for PR 10749 #25052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the eng/common directory with azure-sdk-tools for PR 10749, focusing on improvements to the TestResources-Helpers.ps1 PowerShell script. The changes refactor the conditional logic for handling deployment outputs and add better support for Bicep templates.
- Refactored conditional logic structure for better readability and maintainability
- Added explicit variable for Bicep template detection
- Enhanced comments to clarify the purpose of different deployment output handling paths
Comments suppressed due to low confidence (1)
eng/common/TestResources/TestResources-Helpers.ps1:279
- Missing closing brace for the if statement that begins at line 270. The code structure appears to be malformed after the refactoring.
Write-Host "Test environment settings`n$environmentText`nstored into encrypted $outputFile"
heaths
approved these changes
Aug 5, 2025
weshaggard
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10749 See eng/common workflow