Skip to content

Comments

[Release] sdk/resourcemanager/avs/armavs/3.0.0#24708

Closed
jliusan wants to merge 4 commits intomainfrom
release-avs-armavs-3.0.0-1748503646
Closed

[Release] sdk/resourcemanager/avs/armavs/3.0.0#24708
jliusan wants to merge 4 commits intomainfrom
release-avs-armavs-3.0.0-1748503646

Conversation

@jliusan
Copy link
Member

@jliusan jliusan commented May 29, 2025

Copilot AI review requested due to automatic review settings May 29, 2025 07:38
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label May 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Azure VMware Solution (AVS) Go SDK from version v2 to v3, updating API versions, adding new resources, and refining fake server transports.

  • Bumped module version from v2 to v3 and updated all import paths and API-version headers from 2023-09-01 to 2024-09-01
  • Added new client types (Hosts, ProvisionedNetworks, PureStoragePolicies, SKUs) and many new enum types in constants.go
  • Enhanced fake servers with concurrent dispatch support via dispatchToMethodFake and update code generator metadata

Reviewed Changes

Copilot reviewed 83 out of 83 changed files in this pull request and generated no comments.

Show a summary per file
File Description
fake/*_server.go Replaced sequential dispatch in fake servers with concurrent dispatchToMethodFake logic
*_client.go & examples (*_client_example_test.go) Updated API versions, method signatures, headers, and example patterns from ListPager to Begin* operations
constants.go Introduced numerous new enum types and updated moduleVersion to v3.0.0
client_factory.go Added factory methods for new clients: Hosts, ProvisionedNetworks, PureStoragePolicies, SKUs
README.md Updated Go get import path to v3
CHANGELOG.md Added 3.0.0 release notes including breaking changes and new features
_metadata.json Updated apiVersion to 2024-09-01 and emitterVersion
Comments suppressed due to low confidence (3)

constants.go:675

  • [nitpick] The comment for MountOptionEnum is too terse. Consider expanding it to explain what values it can take and what behavior it controls, e.g., "MountOptionEnum - Mode that describes whether a LUN should be mounted as a datastore or attached as a LUN".
// MountOptionEnum - mount option

client_factory.go:91

  • New factory methods (e.g., NewHostsClient, NewProvisionedNetworksClient, etc.) were added but lack corresponding example tests. Consider adding example snippets or unit tests to validate these new clients.
func (c *ClientFactory) NewHostsClient() *HostsClient {

README.md:20

  • [nitpick] The README import line has been updated for v3; it would be helpful to add a note or example about the new clients introduced (Hosts, SKUs, etc.) to guide users on how to consume those new APIs.
go get github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/avs/armavs/v3

@github-actions
Copy link

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/avs/armavs

@jliusan jliusan closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant