[Release] sdk/resourcemanager/avs/armavs/3.0.0#24708
Closed
Conversation
…ommit: 70bff4eef761ea04c3e971c838861a25ba16751e
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Azure VMware Solution (AVS) Go SDK from version v2 to v3, updating API versions, adding new resources, and refining fake server transports.
- Bumped module version from v2 to v3 and updated all import paths and API-version headers from 2023-09-01 to 2024-09-01
- Added new client types (Hosts, ProvisionedNetworks, PureStoragePolicies, SKUs) and many new enum types in
constants.go - Enhanced fake servers with concurrent dispatch support via
dispatchToMethodFakeand update code generator metadata
Reviewed Changes
Copilot reviewed 83 out of 83 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
fake/*_server.go |
Replaced sequential dispatch in fake servers with concurrent dispatchToMethodFake logic |
*_client.go & examples (*_client_example_test.go) |
Updated API versions, method signatures, headers, and example patterns from ListPager to Begin* operations |
constants.go |
Introduced numerous new enum types and updated moduleVersion to v3.0.0 |
client_factory.go |
Added factory methods for new clients: Hosts, ProvisionedNetworks, PureStoragePolicies, SKUs |
README.md |
Updated Go get import path to v3 |
CHANGELOG.md |
Added 3.0.0 release notes including breaking changes and new features |
_metadata.json |
Updated apiVersion to 2024-09-01 and emitterVersion |
Comments suppressed due to low confidence (3)
constants.go:675
- [nitpick] The comment for MountOptionEnum is too terse. Consider expanding it to explain what values it can take and what behavior it controls, e.g., "MountOptionEnum - Mode that describes whether a LUN should be mounted as a datastore or attached as a LUN".
// MountOptionEnum - mount option
client_factory.go:91
- New factory methods (e.g., NewHostsClient, NewProvisionedNetworksClient, etc.) were added but lack corresponding example tests. Consider adding example snippets or unit tests to validate these new clients.
func (c *ClientFactory) NewHostsClient() *HostsClient {
README.md:20
- [nitpick] The README import line has been updated for v3; it would be helpful to add a note or example about the new clients introduced (Hosts, SKUs, etc.) to guide users on how to consume those new APIs.
go get github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/avs/armavs/v3
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure/azure-rest-api-specs#34346