Skip to content

[azopenai] Updating client to ensure filename is set for file upload. #24171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glecaros merged 3 commits into from
Feb 26, 2025
Merged

[azopenai] Updating client to ensure filename is set for file upload. #24171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d204b5
[azopenai] Updating client to ensure filename is set for file upload.
glecaros Feb 25, 2025
f86508c
changelog
glecaros Feb 25, 2025
edb4ff5
Merge branch 'main' into glecaros/filename-fix
glecaros Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/ai/azopenai/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
### Breaking Changes

### Bugs Fixed
- Fixed a problem that filename would be empty if not explicitly specified in the `UploadFile` operation. (PR#24171)

### Other Changes

Expand Down
2 changes: 1 addition & 1 deletion sdk/ai/azopenai/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "go",
"TagPrefix": "go/ai/azopenai",
"Tag": "go/ai/azopenai_0efed71611"
"Tag": "go/ai/azopenai_4a8ededa66"
}
2 changes: 1 addition & 1 deletion sdk/ai/azopenai/client_custom_files.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ func (client *Client) uploadFileCreateRequest(ctx context.Context, file io.ReadS
return nil, err
}
req.Raw().Header["Accept"] = []string{"application/json"}
fileName := ""
fileName := "file.txt"

if options != nil && options.Filename != nil {
fileName = *options.Filename
Expand Down