Skip to content

Sync eng/common directory with azure-sdk-tools for PR 8475 #23096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Sync eng/common directory with azure-sdk-tools for PR 8475 #23096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0dfe4f6
update the target version of the proxy
scbedd Jun 19, 2024
a277f20
unskip the tests so they fail properly
scbedd Jun 20, 2024
aaeee3b
fix the skips
scbedd Jun 20, 2024
6bdfbd3
update the assets.json
scbedd Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/common/testproxy/target_version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.0.0-dev.20240604.2
1.0.0-dev.20240619.2
2 changes: 1 addition & 1 deletion sdk/containers/azcontainerregistry/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "go",
"TagPrefix": "go/containers/azcontainerregistry",
"Tag": "go/containers/azcontainerregistry_b6bdd049bc"
"Tag": "go/containers/azcontainerregistry_734baeebc4"
}
7 changes: 0 additions & 7 deletions sdk/containers/azcontainerregistry/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import (
"github.com/Azure/azure-sdk-for-go/sdk/azcore/streaming"
"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
"github.com/Azure/azure-sdk-for-go/sdk/internal/mock"
"github.com/Azure/azure-sdk-for-go/sdk/internal/recording"
"github.com/stretchr/testify/require"
)

Expand Down Expand Up @@ -131,9 +130,6 @@ func TestClient_DeleteTag_error(t *testing.T) {
}

func TestClient_GetManifest(t *testing.T) {
if recording.GetRecordMode() == recording.PlaybackMode {
t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22919")
}
startRecording(t)
endpoint, cred, options := getEndpointCredAndClientOptions(t)
ctx := context.Background()
Expand Down Expand Up @@ -616,9 +612,6 @@ func TestClient_UpdateTagProperties_wrongTag(t *testing.T) {
}

func TestClient_UploadManifest(t *testing.T) {
if recording.GetRecordMode() == recording.PlaybackMode {
t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22919")
}
startRecording(t)
endpoint, cred, options := getEndpointCredAndClientOptions(t)
ctx := context.Background()
Expand Down