ListHandles Return additional ClientName field#22997
Merged
tanyasethi-msft merged 1 commit intoAzure:feat/storage/stg93from Jun 6, 2024
tanyasethi-msft:featListHandlesFile
Merged
ListHandles Return additional ClientName field#22997tanyasethi-msft merged 1 commit intoAzure:feat/storage/stg93from tanyasethi-msft:featListHandlesFile
tanyasethi-msft merged 1 commit intoAzure:feat/storage/stg93from
tanyasethi-msft:featListHandlesFile
Conversation
tanyasethi-msft
requested review from
bhansalivikas,
gapra-msft,
jhendrixMSFT,
siminsavani-msft and
souravgupta-msft
as code owners
Member
Author
|
/check-enforcer evaluate |
Member
Author
|
/azp run go - azfile |
|
Azure Pipelines successfully started running 1 pipeline(s). |
souravgupta-msft
approved these changes
Jun 5, 2024
tanyasethi-msft
added a commit
that referenced
this pull request
Jun 13, 2024
* azfile swagger update * service version update * service version upgrade (#22772) * test for clientName in listHandles (#22997) * [STG93][AzFiles] Adding Rename Support to List Ranges API (#23022) * support rename operation in list ranges * test recording * fix lint error * changelog updates * [azdatalake] Added ACL response headers (#23059) * Added ACL response headers and removed few linting errors * changelog updates, linter updates, recording * new test and recordings * lint warnings solve * azblob - linter errors solve + dependancy updates * changelog for dependency updates and few linter errors * pipeline falures fix * changelog release version change to preview * version.go updates in all 3 modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClientName field is returned by List Handle API currently in the codebase. This PR tests this functionality.
API - https://learn.microsoft.com/en-us/rest/api/storageservices/list-handles#response
Since the testing requires File shares to be created, open file handles, and execute the test while holding the handle, the test cannot be made Live in pipeline, and is playback only.
Though live testing was completed successfully as given below -
PS C:\Windows\System32> net use S: \xxxx.file.core.windows.net\tanyafileshare The command completed successfully.
Holding file handle and executing the test -
ClientName field is populated.